Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin to jupyterlab <4.1.0 for now in build-system and dev #84

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 5, 2024

References

Changes

Copy link
Contributor

github-actions bot commented Feb 5, 2024

lite-badge 👈 Try it on ReadTheDocs

@bollwyvl bollwyvl mentioned this pull request Feb 5, 2024
9 tasks
@bollwyvl bollwyvl changed the title pin to jupyterlab <4.1.0 for now in build-system pin to jupyterlab <4.1.0 for now in build-system and dev Feb 5, 2024
@bollwyvl bollwyvl requested a review from jtpio February 5, 2024 13:24
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit adab8ac into jupyterlite:main Feb 5, 2024
11 checks passed
@jtpio
Copy link
Member

jtpio commented Feb 5, 2024

Following-up with the 0.2.2 release.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 5, 2024

conda-forge/jupyterlite-pyodide-kernel-feedstock#16

@jtpio
Copy link
Member

jtpio commented Feb 5, 2024

As @krassowski pointed out on Gitter, the failure was probably related to the use of ~ here:

"@jupyterlab/builder": "~4.0.7",

Which in a way makes sense, because of the overlap check JupyterLab performs (in https://github.com/jupyterlab/jupyterlab/blob/82051a9d0c6dc93677b0b66560aea48d71aaa043/jupyterlab/commands.py#L2252).

Also other extensions using ^ to define their dependency on @jupyterlab/builder are likely not affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants