Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pyodide 0.25.0 #82

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Feb 3, 2024

References

Changes

  • pyodide 0.25.0
    • bump versions all over
  • lint
    • run linters
      • in a fresh env, not sure what we were running before

    • replace black with ruff format
    • also apply ruff to examples/*.ipynb
  • licenses
    • tighten up all (c) 2022 to (c) so we don't have to again
      • seems like the right play, jupyterlab upstream has been doing as well

Upstream notes

Looked through the upstream changes and didn't find anything that looked like a showstopper.

  • await input() does not appear to have changed
  • I didn't observe a measurable difference in load time, as the hard loading of openssl and ssl (1.5mb) is probably dominating any micro-optimizations

Not-on-this-pr

  • proper support for custom/local pyodide lockfiles vs arbitrary wheels
    • started a little bit down this road, but don't think we should to do it on this PR, or potentially on this release.

@bollwyvl bollwyvl marked this pull request as draft February 3, 2024 15:41
Copy link
Contributor

github-actions bot commented Feb 3, 2024

lite-badge 👈 Try it on ReadTheDocs

@bollwyvl bollwyvl marked this pull request as ready for review February 3, 2024 15:55
@bollwyvl bollwyvl requested a review from jtpio February 3, 2024 15:55
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for handling this update!

@jtpio jtpio merged commit e63c22a into jupyterlite:main Feb 5, 2024
10 checks passed
@jtpio
Copy link
Member

jtpio commented Feb 5, 2024

Looked through the upstream changes and didn't find anything that looked like a showstopper.

Right, this can likely go in a 0.2.2 release then it seems.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 5, 2024

Related to the not-on-this-pr work: added #83

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 5, 2024

Ugh, on main:

@jupyterlite/pyodide-kernel-extension: /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/jupyterlab/debuglog.py:57: UserWarning: ValueError: 
  Extensions require a devDependency on @jupyterlab/builder@^4.1.0, you have a dependency on 4.0.12

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 5, 2024

Opened #84

@jtpio
Copy link
Member

jtpio commented Feb 5, 2024

Ugh, on main:

That looks related to the JupyterLab 4.1.0 release. And likely an issue in JupyterLab, as a minor version should not require extensions to update their dependencies.

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Feb 5, 2024

Yeah 4.1.0 is indeed matched by ^4.0.7, to my knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support pyodide 0.25
2 participants