-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STL and STEP file icons #535
Comments
Nice, thanks @o314! Did you make those yourself? Only comment: the round corners are not the same for the underlying file icon and the filename label: Otherwise it looks great! |
Hello, Yes i have done them by myself Here are the patched ones from your remarks PS: they are very big, something from github. download them to see them |
@o314 @martinRenou thank you for your work on the icon. I have a comment on the design: I think that it would look better with a sans-serif font for STL and STP. |
OK. The font was not the good one since i have not found any probing setup in jupyter repo. Here is a file with variations on the font ; the formers are more cad oriented ; the later more commons. Last line is a more comprehensive rework, i finally prefer. The display is a rasterized shot, the file is a vectorized one. PS: edited, add a second variant for new design (w/wo rhombus, eg. an icon for specialized cad) |
Super duper @o314, these looks awesome. I'll leave it up on others to choose any one. So Good :) |
I agree with @martinRenou that the onces matchings the JupyterLab design would be a better choice. Regarding the choice of font, I would go for a thick one because the thin versions may not be very readable at small sizes. |
ok. the 3rd and 4th columns are the declension for the bold font of the same family when available. |
Great. |
@o314 do you have an svg version of your icons handy? |
It seems that the file icon is not showing up in the tab title for STL and STEP files.
On a separate note, it would probably make sense to not use the JupyterCAD logo for these file types, but use a different one for each.
The text was updated successfully, but these errors were encountered: