Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zoom while centering objects #511

Open
arjxn-py opened this issue Oct 21, 2024 · 1 comment
Open

Handle zoom while centering objects #511

arjxn-py opened this issue Oct 21, 2024 · 1 comment

Comments

@arjxn-py
Copy link
Member

Currently if an object is too zoomed out or zoomed in it remains like that while centering objects to the scene.

Originally discussed in #506 (comment)

@arjxn-py arjxn-py added this to the 3.0.0 milestone Oct 21, 2024
@arjxn-py
Copy link
Member Author

arjxn-py commented Nov 4, 2024

Hi, I've been on it and i didn't yet find a solid way to handle it nicely. The reason being that the plan requires the object size, i tried passing the object in customEvent and then used the object in lookatPosition but since object is not a THREE.Object3D instance to get boundingSphere or box to get idea of size. And then there'll be the handling of zoom factor for two cameras.

I'd not want to come this in the way of 3.0.0 unless we have a solid plan. And this is not that significant too. Feel free to let me know your thoughts too.

@martinRenou martinRenou removed this from the 3.0.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants