Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psutil changes in public_ips() causes breaking changes #1039

Open
BwL1289 opened this issue Sep 20, 2024 · 0 comments
Open

Psutil changes in public_ips() causes breaking changes #1039

BwL1289 opened this issue Sep 20, 2024 · 0 comments

Comments

@BwL1289
Copy link

BwL1289 commented Sep 20, 2024

Introduced in 5d4888116a69b8f8edb69e51a22b8d4df3a54741 in jupyter_client/localinterfaces.py, the changes made to public_ips() method breaks existing deployments.

Previously, the following yielded the correct public ip address:

ip = public_ips()[0]
print(ip)  # 10.0.36.XX

Now, it yields the linked local address:

ip = public_ips()[0]
print(ip)  # 169.254.172.2

For now, I am manually filtering out IPs that are one of: ipv4 link local ips (unicast), ipv6 ips (unicast), ipv4 multicast ips, or ipv6 multicast ips, but would love to see this get fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant