Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve err message when trying to connect from another client #258

Open
marimeireles opened this issue Nov 10, 2020 · 2 comments
Open

Improve err message when trying to connect from another client #258

marimeireles opened this issue Nov 10, 2020 · 2 comments

Comments

@marimeireles
Copy link
Member

Discussion: jupyter-xeus/xeus-sqlite#81

@martinRenou where would be a good place to add this function?
xconfiguration maybe?

@martinRenou
Copy link
Member

Maybe yes? I am not sure what form this would take, but maybe a free function or something that tries to factorize a bit of this code that was duplicated in different kernels.

@JohanMabille
Copy link
Member

JohanMabille commented Nov 10, 2020

A better option would be to add this message as a part of the xkernel::start method:

void start(const std::string& kernel_name, const std::string& config_file_name);
void start(const std::string& kernel_name);

That would be a backward incompatible change though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants