Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

weakref to enable gc + setting children with iterable + fix various tooltips #3921

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

weakref to enable gc + setting children with iterable + fix various tooltips #3921

wants to merge 14 commits into from

Conversation

fleming79
Copy link

@fleming79 fleming79 commented May 26, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

Binder 👈 Launch a binder notebook on branch fleming79/ipywidgets/weakref

liamb27 and others added 9 commits June 9, 2024 09:16
@liamb27
Update Widget List.ipynb
d482927 
Example for FloatLogSlider labeled min and max in reverse order; changed it so it is correct.
Update package imports
3fec38a 
1. @lumino/messaging ^2.1 should be ^2.0.1
2. @lumino/messaging ^2.1 should be ^2.0.1
3. istanbul-instrumenter-loader is not maintaned for 6 years
Fix/unify tooltips.
2baf3d6
DirectionalLinkModel - remove link to source and target on cleanup.
53adf75
Add weakref with opt in automatic widget deletion using 'enable_weakr…
b9d043e 
…eference'.
Add Children for Box (and subclasses) to support validation of any ty…
cf8ef63 
…pe of iterable plus a configurable option to omit invalid items (including closed widgets) and log a warning or error.
Update yarn.lock (ran jlpm dlx yarn-berry-deduplicate).
54bd2c6
Run lint.
75da2f9
Fix tests that need dummy comm & update yarn.lock.
0c1dafe
@fleming79 fleming79 changed the title weakref to enable gc + setting children with iterable + fix loading state via jupyter.widget.control + fix various tooltips weakref to enable gc + setting children with iterable + fix various tooltips Jun 10, 2024
vijayi1
vijayi1 reviewed Sep 9, 2024
View reviewed changes
packages/base/src/widget.ts Outdated Show resolved Hide resolved
@fleming79
Copy link
Author

@vijayi1 Thanks for pointing that out. Attached are files for the latest .

files.zip

@vijayi1
Copy link

vijayi1 commented Sep 10, 2024 •
edited
Loading

@fleming79 , the fix works for me, thanks.
the table below summarizes the behavior with and without the fix for the text, dropdown, checkbox and button widgets.
(note line 3, the behavior was inconsistent across widgets previously. if someone expects nothing to be displayed, with the fix they would have to set the tooltip to an empty string)

image

@fleming79 fleming79 mentioned this pull request Sep 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijayi1 vijayi1 vijayi1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fleming79 @vijayi1 @liamb27