Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nbformat when creating an empty cell #46

Open
davidbrochart opened this issue Aug 5, 2022 · 2 comments
Open

Use nbformat when creating an empty cell #46

davidbrochart opened this issue Aug 5, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@davidbrochart
Copy link
Collaborator

Problem

When we set the content of a YNotebook from some source, we create an empty cell if there was no cell originally.

Proposed Solution

We should probably use nbformat for that.

@krassowski
Copy link
Collaborator

What is the status on this? I see that the linked code is no longer here. Asking because I am trying to narrow down some trust issues which appear to originate from ydoc and friends.

Otherwise, I am not sure if spawning up nbformat up is a good idea performance-wise

@davidbrochart
Copy link
Collaborator Author

This issue is not fixed, we are still creating an empty cell here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants