Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the function of the createHttp2Request #93

Open
Java-S12138 opened this issue Aug 22, 2022 · 3 comments
Open

Issues with the function of the createHttp2Request #93

Java-S12138 opened this issue Aug 22, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Java-S12138
Copy link

This is an api that pick a hero in selecting hero's phase.( /lol-champ-select/v1/session/actions/1 )

Using createHttp1Request function there is no problem, and the following code.

const http1PickHero = async () => {
  const credentials = await authenticate()
  let localBody = {
    "completed": true,
    "type": 'pick',
    "championId": '157'
  }
  const response = await createHttp1Request({
    method: "PATCH",
    url: `/lol-champ-select/v1/session/actions/1`,
    body: localBody
  }, credentials)
}

But using createHttp2Request function there is problem.

No any response, also is not an error.
PATCH or POST method not response, but GET have a response.

const http2PickHero = async () => {
  const credentials = await authenticate()
  const session = await createHttpSession(credentials)
  let localBody = {
    "completed": true,
    "type": 'pick',
    "championId": '157'
  }
  const response = await createHttp2Request({
    method: "PATCH",
    url: `/lol-champ-select/v1/session/actions/1`,
    body: localBody
  },session, credentials)
  session.close()
}
@junlarsen
Copy link
Owner

Interesting, thanks for the reporting - will investigate

@junlarsen junlarsen added the bug Something isn't working label Aug 26, 2022
@borsodigerii
Copy link

Any progress on this? I encountered the same problem, no error/response was given when i called createHttp2Request with method POST.

@liyao1520
Copy link

createHttp2Request

me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants