Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@Tag should be processed by Vintage Engine #3602

Closed
adrian-tarau opened this issue Dec 14, 2023 · 1 comment
Closed

@Tag should be processed by Vintage Engine #3602

adrian-tarau opened this issue Dec 14, 2023 · 1 comment

Comments

@adrian-tarau
Copy link

Vintage Engine (which runs JUnit4 tests) converts @ Category into a tag (class name -> tag). However, for consistency, one would want to tag old tests the same as new tests (fast for unit tests, slow for integration tests) and reference them as one set with a single tag. Right now, If you want to run unit tests only, you would have to provide two tags, fast and com.company.UnitTestCategory.

We just need a bit of code in VintageTestDescriptor to handle the @ Tag annotation (probably make JupiterTestDescriptor.getTags public and call it from VintageTestDescriptor ?).

@marcphilipp
Copy link
Member

I can understand where you're coming from, but I don't think mixing JUnit 4 and Jupiter annotations in a test class is a good idea as it's confusing. Each engine has its own way of letting users define tags. In JUnit 4 it's the @Category annotation, in Jupiter it's @Tag, in jqwik it's @Label.

@marcphilipp marcphilipp closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants