Cannot get executing test method in ParameterResolver of @MethodSource factory method

[pxzxj]

Deliverables

• Get test method in ParameterResolver of parameterizedTest factory method. for example below extensionContext.getTestMethod() should return method testWithFactoryMethodWithArguments

public class MyTest {

	@RegisterExtension
	static final IntegerResolver integerResolver = new IntegerResolver();

	@ParameterizedTest
	@MethodSource("factoryMethodWithArguments")
	void testWithFactoryMethodWithArguments(String argument) {
		assertTrue(argument.startsWith("2"));
	}

	static Stream<Arguments> factoryMethodWithArguments(int quantity) {
		return Stream.of(
				arguments(quantity + " apples"),
				arguments(quantity + " lemons")
		);
	}

	static class IntegerResolver implements ParameterResolver {

		@Override
		public boolean supportsParameter(ParameterContext parameterContext,
										 ExtensionContext extensionContext) {
			return parameterContext.getParameter().getType() == int.class;
		}

		@Override
		public Object resolveParameter(ParameterContext parameterContext,
									   ExtensionContext extensionContext) {
			Optional<Method> testMethod = extensionContext.getTestMethod();
			boolean present = testMethod.isPresent();  //false
			return 2;
		}

	}
}

Related issues

• Optionally provide test-scoped ExtensionContext for test-specific callbacks in extensions #3445

[marcphilipp]

Accessing the method from the ParameterContext as mentioned below should work.

junit5/junit-jupiter-api/src/main/java/org/junit/jupiter/api/extension/ParameterResolver.java

Lines 77 to 79 in 49e74f7

	* <p>The {@link java.lang.reflect.Method} or {@link java.lang.reflect.Constructor}
	* in which the parameter is declared can be retrieved via
	* {@link ParameterContext#getDeclaringExecutable()}.

[pxzxj]

@marcphilipp actually parameterContext.getDeclaringExecutable() return the factory method, not test method

[marcphilipp]

@pxzxj Thanks for the feedback! You're correct. This use case is not currently supported.

Team decision: Investigate whether it's feasible to support this use case.

[JojOatXGME]

I took a short look at this issue while preparing #4032. I was not able to reproduce the issue descriped here on the current main branch (d013085). I copied the code from the description and executed it. For me, ExtensionContext.getTestMethod() did return the test method testWithFactoryMethodWithArguments in IntegerResolver.resolveParameter.

[juanplopes]

I've encountered this issue after having the same problem with version 5.10.0. Reading @JojOatXGME's comment, I took a chance and upgraded to 5.11.1 and, indeed, the problem does not happen on that version.

[marcphilipp]

This was indeed fixed in #3905.

@JojOatXGME Thanks for trying to reproduce it! 👍