Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FF7 ] Shadow Flare has an incorrect rendering between PC and PSX #279

Open
DLPB2 opened this issue Sep 16, 2021 · 5 comments
Open

[ FF7 ] Shadow Flare has an incorrect rendering between PC and PSX #279

DLPB2 opened this issue Sep 16, 2021 · 5 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@DLPB2
Copy link

DLPB2 commented Sep 16, 2021

Issue: Shadow Flare (for example) is broken and always has been. An exception may be needed to fix. It's even worse with ffnx than default Aali.

This may be why:

"Alpha blending transparency is broken. The issue is that the PC renderer has two different alpha values (vertex alpha, texture alpha) and the game doesn't specify which one to use (AFAIK), so, sometimes, the correct thing to do is to just use texture alpha, sometimes vertex alpha, and, sometimes, the two should be combined to produce the correct result. The way it works now (with the Custom Driver) is correct most of the time, but not always." - Aali

PSX:
shadow-flare-psx

PC:
shadow-flare-pc

@DLPB2 DLPB2 added the bug Something isn't working label Sep 16, 2021
@julianxhokaxhiu
Copy link
Owner

Thanks for the report, have you got a save that I can use to replicate the issue and can you please share some steps on how to reproduce? This would be really appreciated. I'll look into this but I can't promise any ETA.

@julianxhokaxhiu julianxhokaxhiu added the help wanted Extra attention is needed label Sep 16, 2021
@julianxhokaxhiu julianxhokaxhiu added this to the 1.10 milestone Sep 16, 2021
@julianxhokaxhiu julianxhokaxhiu changed the title Shadow Flare is and always has been broken [ FF7 ] Shadow Flare is and always has been broken Sep 16, 2021
@julianxhokaxhiu julianxhokaxhiu changed the title [ FF7 ] Shadow Flare is and always has been broken [ FF7 ] Shadow Flare has an incorrect rendering between PC and PSX Sep 16, 2021
@DLPB2
Copy link
Author

DLPB2 commented Sep 16, 2021

You can reproduce it just by using the enemy skill Shadow Flare. It will always come out with the wrong colours. We've verified it isn't the texture file.

@julianxhokaxhiu julianxhokaxhiu removed this from the 1.10 milestone Oct 10, 2021
@julianxhokaxhiu
Copy link
Owner

Were you able to find at least a lead around this? I did try to check via RenderDoc but I couldn't find anything strange being done in the pipeline. Should be a deep buried bug in the engine code, as always...

@DLPB2
Copy link
Author

DLPB2 commented Oct 30, 2021

No idea what causes it or anything else... it's likely entirely graphics related

@julianxhokaxhiu
Copy link
Owner

Do you have an idea at which address is this effect being called in the exe? I might have a solution but I need to double check how the blending is set for this texture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants