TypeScript errors - make input optional

[mchepel]

Should getSourceDocumentParser require "input" parameter?

getSourceDocumentParser( input: FilePath | ReadStream, options?: PDFReaderOptions ): PDFReader;

It seems it may not be required

PDFParser* PDFDocumentHandler::GetSourceDocumentParser() { return mParser; }

[julianhille]

why did you close it? from first perspective it looks like a but to be fixed.

[mchepel]

I closed it because there was no feedback for a week, I figured it is very low priority. After not getting this library working for what I needed it for, I just moved on. I will re-open the issue, maybe others will find it useful.

[julianhille]

May I ask what you needed what the lib could not do?

[julianhille]

The args are thrown against

MuhammaraJS/src/DocumentCopyingContextDriver.cpp

Line 270 in 76b9789

Local<Value> newInstance = copyingContext->holder->GetNewPDFReader(args);

which instanciates:

MuhammaraJS/src/ConstructorsHolder.cpp

Line 57 in 76b9789

v8::Local<v8::Value> ConstructorsHolder::GetNewPDFReader(const ARGS_TYPE& args)

need to dig deeper

[mchepel]

May I ask what you needed what the lib could not do?

I needed to fill out a pdf file (find / replace text) but I just could not get it to work. Tried everything I could find online. No errors but no result either. I can share the code if you are interested.

[julianhille]

Please share the code.