-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writer: Loggo emoji writer #41
base: master
Are you sure you want to change the base?
Conversation
The following introduces a emoji log writer. For fun and profit.
This is fantastic! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs moar tests
How can I test this?I have a charm that already logs with this internally and I would love to be able to use this also in conjunction with stuff like "juju debug-log". The visibility for specific log events helps alot to discover when stuff goes sideways or even just info. |
I think that "juju debug-log" will have a hard time here perhaps, thats one thing I would like to test etc. |
@erik78se we'll just ensure that it gets written, won't take me long... will get it done Monday 👯 |
The following ensures that we actually write out a emoji for the correct level.
When can I use this ? |
I need to come back around and merge this into Juju. |
Cool, how do I add these icons myself in my logs if I'd like to lets say
add a charm-custom emoji?
logger.info( ????? )
…On Tue, Aug 10, 2021 at 12:25 PM Simon Richardson ***@***.***> wrote:
I need to come back around and merge this into Juju.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGPVK7EN7LZQ3ESKMY3D7LT4D5CNANCNFSM47WTIYAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
your charm can add whatever characters it wants to its log lines. Something
like:
log.warning("\uemoji my message")
for whatever the codes are for the emojis you want.
…On Tue, Aug 10, 2021, 06:49 Erik Lönroth ***@***.***> wrote:
Cool, how do I add these icons myself in my logs if I'd like to lets say
add a charm-custom emoji?
logger.info( ????? )
On Tue, Aug 10, 2021 at 12:25 PM Simon Richardson ***@***.***>
wrote:
> I need to come back around and merge this into Juju.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#41 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAGPVK7EN7LZQ3ESKMY3D7LT4D5CNANCNFSM47WTIYAA
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
>
> .
>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRQ7ODXDGJTQYVDVRHOHDT4D72PANCNFSM47WTIYAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
Right, I'll try it out =)
On Tue, Aug 10, 2021 at 1:23 PM John Arbash Meinel ***@***.***>
wrote:
… your charm can add whatever characters it wants to its log lines. Something
like:
log.warning("\uemoji my message")
for whatever the codes are for the emojis you want.
On Tue, Aug 10, 2021, 06:49 Erik Lönroth ***@***.***> wrote:
> Cool, how do I add these icons myself in my logs if I'd like to lets say
> add a charm-custom emoji?
>
> logger.info( ????? )
>
> On Tue, Aug 10, 2021 at 12:25 PM Simon Richardson ***@***.***>
> wrote:
>
> > I need to come back around and merge this into Juju.
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <#41 (comment)>, or
> > unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AAGPVK7EN7LZQ3ESKMY3D7LT4D5CNANCNFSM47WTIYAA
> >
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> > <
>
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
> >
> > or Android
> > <
>
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
> >
> > .
> >
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#41 (comment)>, or
> unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AABRQ7ODXDGJTQYVDVRHOHDT4D72PANCNFSM47WTIYAA
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGPVK7POXNPTSBC6JIHSPDT4ED45ANCNFSM47WTIYAA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
The following introduces an emoji log writer. For fun and profit.