Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Writer: Loggo emoji writer #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

SimonRichardson
Copy link
Member

@SimonRichardson SimonRichardson commented Jul 2, 2021

The following introduces an emoji log writer. For fun and profit.

Screenshot from 2021-07-02 13-01-15

The following introduces a emoji log writer. For fun and profit.
@erik78se
Copy link

erik78se commented Jul 2, 2021

This is fantastic!

Copy link
Member

@jameinel jameinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs moar tests

@erik78se
Copy link

erik78se commented Jul 2, 2021

How can I test this?I have a charm that already logs with this internally and I would love to be able to use this also in conjunction with stuff like "juju debug-log". The visibility for specific log events helps alot to discover when stuff goes sideways or even just info.

@erik78se
Copy link

erik78se commented Jul 2, 2021

I think that "juju debug-log" will have a hard time here perhaps, thats one thing I would like to test etc.

@SimonRichardson
Copy link
Member Author

@erik78se we'll just ensure that it gets written, won't take me long... will get it done Monday 👯

The following ensures that we actually write out a emoji for the correct
level.
@erik78se
Copy link

When can I use this ?

@SimonRichardson
Copy link
Member Author

I need to come back around and merge this into Juju.

@erik78se
Copy link

erik78se commented Aug 10, 2021 via email

@jameinel
Copy link
Member

jameinel commented Aug 10, 2021 via email

@erik78se
Copy link

erik78se commented Aug 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants