Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse regular expressions #45

Open
achudnov opened this issue Oct 14, 2013 · 2 comments
Open

Parse regular expressions #45

achudnov opened this issue Oct 14, 2013 · 2 comments

Comments

@achudnov
Copy link
Member

Right now regular expression bodies are not validated (in both dev and es5) and are stored as a string. While this might be okay for some uses, it would be better if we had a grammar for regexps in the AST and parsed and validated regexps. Shouldn't be hard, just would take some time and diligence. Any takers?

@michaelficarra
Copy link

I wouldn't mind doing this. Should be pretty easy. I can base it on https://github.com/michaelficarra/esfuzz/blob/master/src/nodes/RegExp.coffee

@achudnov
Copy link
Member Author

@michaelficarra, thanks for the offer! Feel free to work on this. This is a low-priority issue for me and, given there are a lot of other issues to address, I don't anticipate working on this anytime soon. Please, submit pull requests against the es5 branch. Note, I'm aware that some of the tests for that branch are broken and I'm working to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants