Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install via pip requires 'cryptography' #70

Open
geoffklee opened this issue Feb 17, 2018 · 2 comments
Open

Install via pip requires 'cryptography' #70

geoffklee opened this issue Feb 17, 2018 · 2 comments
Assignees
Labels

Comments

@geoffklee
Copy link

geoffklee commented Feb 17, 2018

Installing via pip alongside the system python on 10.13.3 seems to be missing a dependency. After installing, I get the message

 File "/Library/Python/2.7/site-packages/urllib3/contrib/pyopenssl.py", line 47, in <module>
    from cryptography import x509
ImportError: No module named cryptography

So, it looks as if cryptography is actually an unresolved dependency of pyopenssl, which is included in urllib3.

Interestingly, I don't get this issue if I install into a virtualenv - pip installs cryptography along with all the other packages...

@sheagcraig
Copy link
Collaborator

Hello @gkluoe

I need to update the README here, as it talks about JSSImporter (which doesn't use requests any longer), and I need to update the package setup to work around this. And also remove references to easy_install!

You are correct that cryptography is needed; I forget the details already, but this is a change from older versions of macOS. I'll put this on the TODO list, but for anyone checking this issue out, the resolution is of course pip install cryptography.

@sheagcraig sheagcraig self-assigned this Apr 24, 2018
@sheagcraig sheagcraig added the bug label Apr 24, 2018
@grahampugh
Copy link
Member

@gkluoe can you check with the latest version of python-jss? We haven't updated the version in pip for a while (I think only Shea has the rights to do that), so you'll have to install from source (or just use the JSSImporter install package and make sure to add /Library/Application Support/JSSImporter to your python path.

I'm no expert, but @mosen changed the requests adapter method in May 2018, removing pyopenssl, so I don't think you will have the problem any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants