Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.2 #19

Closed
wants to merge 0 commits into from
Closed

Release 2.0.2 #19

wants to merge 0 commits into from

Conversation

kemitchell
Copy link
Member

PR to propose releasing v2.0.2, with the new handwritten parser.

If there is any reason to think the new implementation might return different results than the old, generated parser, we should bump SemVer major instead, and perhaps do a 3.0.0-pre.1.

@motet-a
Copy link
Member

motet-a commented Jun 17, 2017

Since there were not many tests in spdx-expression-parse but other packages like spdx-correct or validate-npm-package-license contain much more tests, it is probably a good idea to test those with [email protected] before publishing it (npm link?).

@motet-a
Copy link
Member

motet-a commented Jun 17, 2017

I have doubts about parentheses. I just opened #20.

@kemitchell
Copy link
Member Author

I've just run the spdx-correct and validate-npm-package-license test suites with proposed 2.0.2. All tests pass.

@kemitchell
Copy link
Member Author

@motet-a, would you like to register motet-a on npmjs.com? I will give you publish permissions on the package.

@motet-a
Copy link
Member

motet-a commented Jul 4, 2017

@kemitchell Done, I have just registered motet-a.

I used to have https://www.npmjs.com/~motet_a, but how stupid can I be to mix up dashes and underscores…

@kemitchell
Copy link
Member Author

I've added you as a "contributor". You can publish with npm publish.

I'll continue to open pull requests for significant releases going forward. Do what you think best. If you have questions, don't be afraid to ask, publicly or privately.

@kemitchell kemitchell deleted the release-2.0.2 branch July 6, 2017 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants