Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export combineRanges() function #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Export combineRanges() function #17

wants to merge 1 commit into from

Conversation

piranna
Copy link

@piranna piranna commented Jul 30, 2018

Export the combineRanges() function so it can be used directly.

@dougwilson dougwilson self-assigned this Jul 30, 2018
@piranna
Copy link
Author

piranna commented Nov 17, 2018

Any update with this? Can it be merged?

dougwilson
dougwilson suggested changes Nov 17, 2018
View reviewed changes
Copy link
Contributor

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I must havre forgotten to comment when I added the tags: it just needs documentation added about these new exports and new tests written to test their usage now that users can provide who knows what types of input into them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougwilson dougwilson dougwilson requested changes

Assignees

@dougwilson dougwilson

Labels
needs docs needs tests pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piranna @dougwilson