Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsfe.js.org #8552

Merged
merged 2 commits into from
Oct 2, 2023
Merged

jsfe.js.org #8552

merged 2 commits into from
Oct 2, 2023

Conversation

JulianCataldo
Copy link
Contributor

@JulianCataldo JulianCataldo commented Oct 1, 2023

jsfe.netlify.app
json-schema-form-element (Source)

@MattIPv4 MattIPv4 changed the title jsfe.netlify.app jsfe.js.org Oct 1, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 As the CI error notes, your entry in cnames_active.js needs to be in alphabetical order, and doesn't need the https:// scheme prefix.

Fixing ordering and remove unneeded protocol prefix
@JulianCataldo
Copy link
Contributor Author

My bad! Fixed it, thank you.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, site has content based on https://jsfe.netlify.app/

I trust that your site is configured ready to work with the requested js.org subdomain.

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed invalid labels Oct 2, 2023
@indus
Copy link
Member

indus commented Oct 2, 2023

Welcome https://jsfe.js.org/AllFeature

@indus indus merged commit 83d2daf into js-org:master Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants