storelocator.js.org

[yoriiis]

• There is reasonable content on the page (see: No Content)
• I have read and accepted the Terms and Conditions

[MattIPv4]

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance storelocator.js.org.

[yoriiis]

Hello @MattIPv4,

The CNAME file is already present
https://github.com/storelocatorjs/storelocatorjs.github.io/blob/main/docs/CNAME

I use GitHub Actions to deploy GitHub Pages, so this is linked to a branch. The last deployment job contains an artifact with the content of the website and the "CNAME" file is present
https://github.com/storelocatorjs/storelocatorjs.github.io/actions/runs/5513367345

Let me know if I need to make any other changes. Thanks!

Docs: https://docs.github.com/en/pages/getting-started-with-github-pages/configuring-a-publishing-source-for-your-github-pages-site#publishing-with-a-custom-github-actions-workflow

[MattIPv4]

Ah, if you're using the new Actions workflow way of deploying I believe you don't need the CNAME file, you just need to set the subdomain in your settings.

[MattIPv4]

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/storelocatorjs/storelocatorjs.github.io/tree/main/docs

[indus]

I've already added your requested subdomain to JS.ORGs zonefile. But as you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI:
#7853 (comment)
#8364 (comment)

[yoriiis]

@indus I changed the deployment to use a branch as a trigger and the website is available.

I have some questions:

1. Can I go back to GitHub Action mode? If I understand correctly, this manipulation was just to "activate" the site
2. Is the https checkbox available?
   
3. I also have another domain with your extension (thanks by the way :)), I had made the request when I was using Github Pages with a branch then I changed it to use GitHub Action. Deployment works but there is a DNS warning
   

Thanks

[indus]

I don't have a clear answer to any of the three questions. Everything was easy without workflows They made the process complicated. I would suggest to just try different settings until it works ;-) Sorry

[MattIPv4]

I know other folks in the past have got stuck with the Actions workflow. Every time I have recommended reaching out to GitHub Support, as I suspect this is a breakage in this new style of deployment, yet I don't think anyone has. If you aren't able to get it to work toggling settings, I will once again recommend reaching out to support and see what they say :)

[indus]

@yoriiis I've just checked your page and it looks ok to me: https://storelocator.js.org
Do you think it is ok now or do you wnat to change something and wait with th merge?

[yoriiis]

@indus Yes it is ok, you can merge. Thanks for the support. I will check with the GitHub support if needed

[indus]

Welcome https://storelocator.js.org