Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dynamotion.js.org #8360

Merged
merged 3 commits into from
Jul 13, 2023
Merged

dynamotion.js.org #8360

merged 3 commits into from
Jul 13, 2023

Conversation

ryzmae
Copy link
Contributor

@ryzmae ryzmae commented Jul 9, 2023

@MattIPv4 MattIPv4 changed the title Update cnames_active.js dynamotion.js.org Jul 9, 2023
MattIPv4
MattIPv4 requested changes Jul 9, 2023
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Do you have a link to where we can preview your content prior to merging this PR?

❌ Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

@MattIPv4 MattIPv4 added invalid awaiting response This PR is waiting for a response from the requester labels Jul 9, 2023
@ryzmae
Copy link
Contributor Author

ryzmae commented Jul 9, 2023

so this time I put it in the d lines so what now

@MattIPv4
Copy link
Member

MattIPv4 commented Jul 9, 2023

It needs to be in alphabetical order, not just the first letter, the whole entry. The CI has even given you annotations for exactly where it should be.

@ryzmae
Copy link
Contributor Author

ryzmae commented Jul 11, 2023

but how can you help me to do this?

@MattIPv4
Copy link
Member

Edit the PR, move the line you've added to the correct place...

@ryzmae
Copy link
Contributor Author

ryzmae commented Jul 11, 2023

in which line so ? im not good at English

@MattIPv4
Copy link
Member

After line 876, as the CI error shows.

@indus indus added add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages and removed invalid awaiting response This PR is waiting for a response from the requester labels Jul 13, 2023
@indus
Copy link
Member

indus commented Jul 13, 2023

@ryzmae I fixed it for you.
Welcome http://dynamotion.js.org

@indus indus merged commit 1eff6a7 into js-org:master Jul 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 requested changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain external page This PR has a target of a site that isn't GitHub Pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryzmae @MattIPv4 @indus