Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vento.js.org #8345

Merged
merged 1 commit into from
Jul 3, 2023
Merged

vento.js.org #8345

merged 1 commit into from
Jul 3, 2023

Conversation

kwaa
Copy link
Contributor

@kwaa kwaa commented Jul 1, 2023

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance vento.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Jul 1, 2023
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Jul 1, 2023
@indus
Copy link
Member

indus commented Jul 1, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But like Matt said the CNAME is missing. As you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)
I'll merge after we have "contact". Please keep this PR open.

@kwaa
Copy link
Contributor Author

kwaa commented Jul 1, 2023

@oscarotero Looks like CNAME doesn't work. can you take a look?

Perhaps deploying from artifacts is different from the common branching method and needs to be modified in Repo Settings.

@oscarotero
Copy link
Contributor

I just changed the custom domain in the GitHub Page settings. I hope it works well now.

imaxe

@kwaa kwaa requested a review from MattIPv4 July 2, 2023 11:59
@MattIPv4
Copy link
Member

MattIPv4 commented Jul 2, 2023

It looks like there is a redirect loop?

curl -I https://vento.js.org/
HTTP/2 301 
date: Sun, 02 Jul 2023 17:02:50 GMT
content-type: text/html
content-length: 162
location: https://vento.js.org/
x-github-request-id: 0E38:8616:29A51CA:2B00B60:64A1AD8E

This looks to be a similar issue to previous folks we've seen using GitHub's new Pages deployment. Might I suggest you reach out to GitHub support to see what's going on? They appear to have broken something with this new method. Feel free to cc me ([email protected]).

@kwaa
Copy link
Contributor Author

kwaa commented Jul 2, 2023

@oscarotero Maybe I can modify the current actions to push to the gh-pages branch to avoid this problem?

@oscarotero
Copy link
Contributor

I finally got it to work following this comment #7853 (comment)

I set the classic deploy option (from branch) and then set again to GitHub action mode. This seems to fix the issue.

https://vento.js.org/

@indus indus merged commit e8c135b into js-org:master Jul 3, 2023
1 check passed
@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Jul 3, 2023
@MattIPv4 MattIPv4 mentioned this pull request Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants