Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Support cleanup-ignore comment #23

Open
MattIPv4 opened this issue Mar 15, 2023 · 3 comments
Open

Cleanup: Support cleanup-ignore comment #23

MattIPv4 opened this issue Mar 15, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@MattIPv4
Copy link
Member

Add support for entries having a // cleanup-ignore comment on them, which will allow them to skip the validation process for cleanup.

This will also involve a minor change to the validate logic for detecting/formatting the file, to allow // cleanup-ignore or // noCF cleanup-ignore.

@MattIPv4
Copy link
Member Author

Reference js-org/js.org@1d8e313 for the current set of subdomains that should be given this comment in cnames_active.js@js-org/js.org

@indus
Copy link
Member

indus commented Mar 16, 2023

@MattIPv4 isn't it problematic to parse the comments?
I could live with a new list cleanup-ignore.json with an array of subdomains to skip as well. It is of course nicer to have everything in one file but if it gets to complicated or is prone to failures I think we should look for the easiest solution.

@MattIPv4
Copy link
Member Author

Parsing comments should be fine, especially given how strict the formatting already is in the file.

I went for comments over a dedicated file etc. to folllow what is somewhat a standard with things like eslint, typescript and prettier ignore comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants