Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2043 performance improvement #2072

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

tedeschia
Copy link
Contributor

Resolves performance issues for large data validation described at #2043:

  • Arrays of ValidationError
    • Mutate the array with splice instead of using concat
    • ValidationError class
  • Add the new option "disableStackTrace" to stop capturing stack trace when instantiating ValidationError
    • Stop ValidationError extending Error, so no need to call super() when instantiating ValidationError

This PR also fix the issue on ValidationError that broke several tests in #2044

@tedeschia
Copy link
Contributor Author

Hi @jquense, do you think we could merge this PR? it solves all tests issues. Please let me know if I can do anything else to complete it. Thanks!

@jquense jquense merged commit 4de9ea0 into jquense:master Aug 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants