Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate the prompt command behind a prompt feature #2160

Closed
jqnatividad opened this issue Sep 21, 2024 Discussed in #2155 · 3 comments · Fixed by #2163
Closed

Gate the prompt command behind a prompt feature #2160

jqnatividad opened this issue Sep 21, 2024 Discussed in #2155 · 3 comments · Fixed by #2163
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.

Comments

@jqnatividad
Copy link
Owner

Discussed in #2155

Originally posted by derekmahar September 20, 2024
How can I exclude crate rfd from the qsv build? Crate rfd breaks my qsv build on a headless server that has no window manager because it indirectly requires crate wayland-sys which fails to build because wayland-sys cannot find wayland-client which isn't installed.

@jqnatividad jqnatividad added the enhancement New feature or request. Once marked with this label, its in the backlog. label Sep 21, 2024
@derekmahar
Copy link

derekmahar commented Sep 23, 2024

Thank you for implementing the prompt feature. Did you intend for all_features to include prompt? all_features in Cargo.toml includes prompt, but FEATURES specifies that all_features does not include prompt. Is it possible to instruct cargo build to exclude a feature that a feature list includes?

@derekmahar
Copy link

derekmahar commented Sep 23, 2024

Note that I now successfully build qsv using the command

cargo build --release --locked --features "feature_capable apply fetch foreach geocode lens luau polars python to"

Would it be useful to group these features in a feature list named console_features, for example?

@jqnatividad
Copy link
Owner Author

Glad to know you can build qsv now on your headless server.

As for prompt not being documented in FEATURES.md, that was an oversight on my part and have since updated it.

As for creating a console_features grouping feature, let's bookmark that for now until we get more commands that require a window manager. Right now, prompt is the only one - though technically, you can actually still build and run it headless by just installing libwayland-dev like we do on the publishing workflows.

- name: apt-get update Ubuntu, libwayland-dev
run: |
sudo apt-get update
sudo apt-get install libwayland-dev

All commands requiring a GUI, going forward, will be on qsv pro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants