Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong IP format when using the "prompt IP" option (or "select IP" option) #67

Open
pvi-github opened this issue Jan 12, 2023 · 1 comment

Comments

@pvi-github
Copy link

pvi-github commented Jan 12, 2023

Hello,

In current Android version of Fwknop2 when you choose "Prompt IP" it lets us type this kind of string

[0-9]*\.[0-9]*

If you try to type a second dot it will not accept it and type nothing.

A more correct regexp format would be : [0-9]*\.[0-9]*\.[0-9]*\.[0-9]* allowing to type all the 4 parts of the IP

Note : The same problem shows up when you try to use the fixed IP option. Maybe the string format control function is common.

Disclaimer : I dont know how string format it controlled there in this field but it made me imagine a regexp... at least i hope it will lead devs in the right direction.

@pvi-github pvi-github changed the title Wrong IP format when using the "proompt IP" option Wrong IP format when using the "prompt IP" option Jan 25, 2023
@pvi-github pvi-github changed the title Wrong IP format when using the "prompt IP" option Wrong IP format when using the "prompt IP" option (or "select IP" option) Jan 25, 2023
@pvi-github
Copy link
Author

Fixed a typo in the title. And added that the bug also concerns the "Select IP" option.

poke @jp-bennett @mrash ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant