malformed QR code crashes the app / QR code text trimming

[leonyu]

Two problems discovered:

• Certain QR code would crash the app
• QR code text is imported as is, no trimming/verification is done until user hits save

In attempt to generate my own QR code, I ran the following command.

 fwknop --key-gen | qrencode -t UTF8

The above generated QR code would crash the app.

Afterwards, I tried edit the ouptut of fwknop --key-gen to conform to that of OpenWrt package (KEY_BASE64:{CODE} HMAC_KEY_BASE64:{CODE}). In the process also learned that the app doesn't attempt to trim the text from QR code.

This resulted in the save operation telling me the Base64 is invalid. It took me awhile to figure out that it was merely due to the fact that there is a space at the end of the Base64 code.

[jp-bennett]

The qr code processing does not have much error checking built in atm. I'll take a look at this, and at least fix the crash. One more trick you might find interesting is this script: https://github.com/mrash/fwknop/blob/master/extras/console-qr/console-qr.sh

You pipe a fwknop access.conf file into it, and it generates qr codes from each stanza.