socket: remove fanout support when using older linux kernels #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In jow-@0662de6 the fanout_args struct is used, which is only availble on linux kernels >= 5.11 (https://github.com/torvalds/linux/commit> This commit adds a check and does not compile the fanout pieces when on kernels < 5.11. Signed-off-by: Matthias FRANCK <[email protected]>
|
I was wondering if we should maybe simply copy the relevant kernel headers into the tree, like we did for others already: This way the build becomes kernel version agnostic. What do you think? |
|
Hi, that would be possible as well. However we might experience some runtime errors, isn't that a problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0662de6 the fanout_args struct is used, which is only availble on linux kernels >= 5.11 (https://github.com/torvalds/linux/commit> This commit adds a check and does not compile the fanout pieces when on kernels < 5.11.