Laravel 8

[Rokela]

Please add support of Laravel 8

[Niellles]

I just took a quick look at this. Are you getting any errors?

I currently don't have a Laravel 8 install to test on. However a couple of Google searches makes me believe that Laravel 8 uses Guzzle 7, while this package won't accept Guzzle 7. Could you check this for me?

[Rokela]

Hi! You are absolutely right! The problem with Guzzle 7 [2@ws01 lara8]$ composer require jcf/geocode Using version ^1.4 for jcf/geocode ./composer.json has been updated Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages. Problem 1 - Installation request for jcf/geocode ^1.4 -> satisfiable by jcf/geocode[1.4.0]. - Conclusion: remove guzzlehttp/guzzle 7.2.0 - Conclusion: don't install guzzlehttp/guzzle 7.2.0 - jcf/geocode 1.4.0 requires guzzlehttp/guzzle ~5.3|~6.0 -> satisfiable by guzzlehttp/guzzle[5.3.x-dev, 6.5.x-dev]. - Can only install one of: guzzlehttp/guzzle[6.5.x-dev, 7.2.0]. - Can only install one of: guzzlehttp/guzzle[5.3.x-dev, 7.2.0]. - Installation request for guzzlehttp/guzzle (locked at 7.2.0, required as ^7.0.1) -> satisfiable by guzzlehttp/guzzle[7.2.0]. Installation failed, reverting ./composer.json to its original content. [2@ws01 lara8]$ вт, 3 нояб. 2020 г. в 02:15, Niellles <[email protected]>:

…

I just took a quick look at this. Are you getting any errors? I currently don't have a Laravel 8 install to test one. However a couple of Google searches makes me believe that Laravel 8 uses Guzzle 7, while this package won't accept Guzzle 7. Could you check this for me? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVJNQQG75XFNDROYYTC5CTSN44RLANCNFSM4RMUO4OQ> .

[Niellles]

Should be a quick fix:

 "require": {
        "php": ">=5.4.0",
        "guzzlehttp/guzzle": "~5.3|~6.0|~7.0"
    }

From there it's fingers crossed and hope that nothing else breaks.

Would you be able to change and test this? After that you should probably make a PR, however this repo looks to be kinda abandoned.

[Niellles]

I've made this change in my fork (from which there's still a pending pull request). Since you've got a working Laravel 8 install could you try it out?

Installing from a Github repo should go something like this:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Niellles/geocode/"
        }
    ],
    "require": {
        "jcf/geocode": "dev-laravel8-hotfix"
    }
}

[Rokela]

Hi! I just tried it. Config { "repositories": [ { "type": "vcs", "url": "https://github.com/Niellles/geocode/" } ], "require": { "jcf/geocode": "laravel8-hotfix" } } is wrong. Right config is: { "repositories": [ { "type": "vcs", "url": "https://github.com/Niellles/geocode/" } ], "require": { "jcf/geocode": "*" } } чт, 5 нояб. 2020 г. в 17:01, Niellles <[email protected]>:

…

I've made this change in my fork <https://github.com/Niellles/geocode/blob/laravel8-hotfix/> (from which there's still a pending pull request). Since you've got a working Laravel 8 install could you try it out: { "repositories": [ { "type": "vcs", "url": "https://github.com/Niellles/geocode/" } ], "require": { "jcf/geocode": "laravel8-hotfix" } } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVJNQTCT3PIKKZOX4TC5ETSOKV4HANCNFSM4RMUO4OQ> .

[Niellles]

I edited it later, has to be "dev-laravel8-hotfix" instead of "laravel8-hotfix" that you got in your email. If you try the edited comment, it should work.

[Rokela]

I tried it. All works excellently. Thank You very much! ср, 18 нояб. 2020 г. в 00:50, Niellles <[email protected]>:

…

I edited it later, has to be "dev-laravel-hotfix" instead of "laravel-hotfix" that you got in your email. If you try the edited comment, it should work. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVJNQW3YCYMSJSHSCKIK7TSQLVYRANCNFSM4RMUO4OQ> .