Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate do_subset_xts() and _do_subset_xts() #377

Open
joshuaulrich opened this issue Oct 12, 2022 · 0 comments
Open

Consolidate do_subset_xts() and _do_subset_xts() #377

joshuaulrich opened this issue Oct 12, 2022 · 0 comments

Comments

@joshuaulrich
Copy link
Owner

_do_subset_xts() is used everywhere except for src/na.c. Test that using it in src/na.c doesn't break anything internally (i.e. na.omit.xts() and na.exclude.xts()).

We also need to ensure it doesn't change the output of na_omit_xts(), which is callable externally via R_RegisterCCallable() and xtsAPI.h. That said, neither of the *do_subset_xts() functions are directly callable externally (i.e. via R_RegisterCCallable() or via xtsAPI.h), so we can swap the functionality of one for the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant