From c0e74618d9ab4f5ca96e007c7cdaec661516c409 Mon Sep 17 00:00:00 2001 From: Eitot Date: Wed, 10 Jul 2024 15:54:07 +0200 Subject: [PATCH 1/5] Use build settings for several Info.plist keys These are already defined in the build settings. --- Vienna/Info.plist | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Vienna/Info.plist b/Vienna/Info.plist index fa820940ef..200e5fe986 100644 --- a/Vienna/Info.plist +++ b/Vienna/Info.plist @@ -3,7 +3,7 @@ CFBundleDevelopmentRegion - en + $(DEVELOPMENT_LANGUAGE) CFBundleDocumentTypes @@ -68,7 +68,7 @@ CFBundleExecutable - Vienna + $(EXECUTABLE_NAME) CFBundleHelpBookFolder Vienna.help CFBundleHelpBookName @@ -78,9 +78,9 @@ CFBundleInfoDictionaryVersion 6.0 CFBundleName - Vienna + $(PRODUCT_NAME) CFBundlePackageType - APPL + $(PRODUCT_BUNDLE_PACKAGE_TYPE) CFBundleShortVersionString VCS_TAG :VCS_SHORT_HASH: CFBundleSignature From ac19af035980ceb208646886224263e6ce3df264 Mon Sep 17 00:00:00 2001 From: Eitot Date: Thu, 11 Jul 2024 11:40:16 +0200 Subject: [PATCH 2/5] Change application category from "utilities" to "news" This will affect the default folder name in Launchpad when Vienna is used to create a folder. The category "news" is recommended by Apple for feed readers (s. https://developer.apple.com/app-store/categories/) --- Vienna/Info.plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Vienna/Info.plist b/Vienna/Info.plist index 200e5fe986..11a103e8d7 100644 --- a/Vienna/Info.plist +++ b/Vienna/Info.plist @@ -114,7 +114,7 @@ CFBundleVersion VCS_NUM LSApplicationCategoryType - public.app-category.utilities + public.app-category.news LSFileQuarantineEnabled LSMinimumSystemVersion From 09e1ecd1189efbc3c87c0c65d628f8fe809d2aa7 Mon Sep 17 00:00:00 2001 From: Eitot Date: Fri, 12 Jul 2024 09:12:29 +0200 Subject: [PATCH 3/5] Update copyright string in Info.plist --- Vienna/Info.plist | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Vienna/Info.plist b/Vienna/Info.plist index 11a103e8d7..b88032de2b 100644 --- a/Vienna/Info.plist +++ b/Vienna/Info.plist @@ -129,7 +129,7 @@ NSAppleScriptEnabled YES NSHumanReadableCopyright - © 2004–2023 The Vienna RSS Project + © 2004–2024 The Vienna RSS Project NSMainNibFile MainMenu NSPrincipalClass From 3301541019ef05d1d295459ed0bfd4c29c5e0d96 Mon Sep 17 00:00:00 2001 From: Eitot Date: Fri, 20 Sep 2024 11:58:09 +0200 Subject: [PATCH 4/5] Add additional files to Xcode project --- Vienna.xcodeproj/project.pbxproj | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/Vienna.xcodeproj/project.pbxproj b/Vienna.xcodeproj/project.pbxproj index c147cac0f8..72458535cd 100644 --- a/Vienna.xcodeproj/project.pbxproj +++ b/Vienna.xcodeproj/project.pbxproj @@ -629,6 +629,10 @@ F6B3561325616302008CA1ED /* DownloadItem.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = DownloadItem.h; sourceTree = ""; }; F6B3561425616313008CA1ED /* DownloadItem.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = DownloadItem.m; sourceTree = ""; }; F6B76B43284B492E009961AD /* NSPredicateEditor+Private.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; lineEnding = 0; path = "NSPredicateEditor+Private.h"; sourceTree = ""; }; + F6BD1FD82C9D7DD40075D04F /* .clang-format */ = {isa = PBXFileReference; lastKnownFileType = text; path = ".clang-format"; sourceTree = ""; }; + F6BD1FDA2C9D7DD40075D04F /* .swiftlint.yml */ = {isa = PBXFileReference; lastKnownFileType = text.yaml; path = .swiftlint.yml; sourceTree = ""; }; + F6BD1FDC2C9D7E230075D04F /* CONTRIBUTING.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = CONTRIBUTING.md; sourceTree = ""; }; + F6BD1FDD2C9D7E2E0075D04F /* LICENCE.md */ = {isa = PBXFileReference; lastKnownFileType = net.daringfireball.markdown; path = LICENCE.md; sourceTree = ""; }; F6C9DA6E271BB3BB00FC3027 /* RSSFeed.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RSSFeed.h; sourceTree = ""; }; F6C9DA6F271BB3BB00FC3027 /* RSSFeed.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = RSSFeed.m; sourceTree = ""; }; F6C9DA71271BB55000FC3027 /* AtomFeed.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = AtomFeed.h; sourceTree = ""; }; @@ -718,6 +722,7 @@ F63B7D701F1CD001002F71BF /* External */, 19C28FB0FE9D524F11CA2CBB /* Products */, 439824171666B31700FFE219 /* Scripts */, + F6BD1FD72C9D7D9D0075D04F /* Configs */, ); indentWidth = 4; name = Vienna; @@ -844,8 +849,10 @@ 4398241E1666B3DB00FFE219 /* Credits.rtf */, 439824201666B3DB00FFE219 /* CHANGES */, 439824221666B3DB00FFE219 /* notes.html */, - 439824231666B3DB00FFE219 /* README.md */, 439824241666B3DB00FFE219 /* Release Instructions.md */, + 439824231666B3DB00FFE219 /* README.md */, + F6BD1FDD2C9D7E2E0075D04F /* LICENCE.md */, + F6BD1FDC2C9D7E230075D04F /* CONTRIBUTING.md */, ); name = Documentation; sourceTree = ""; @@ -1058,6 +1065,15 @@ path = Files; sourceTree = ""; }; + F6BD1FD72C9D7D9D0075D04F /* Configs */ = { + isa = PBXGroup; + children = ( + F6BD1FD82C9D7DD40075D04F /* .clang-format */, + F6BD1FDA2C9D7DD40075D04F /* .swiftlint.yml */, + ); + name = Configs; + sourceTree = ""; + }; F6C9DA74271BBA4800FC3027 /* XML-based feeds */ = { isa = PBXGroup; children = ( From 22c6dc6a93120c32a7d033b99905195892bc3c18 Mon Sep 17 00:00:00 2001 From: Eitot Date: Fri, 20 Sep 2024 11:58:58 +0200 Subject: [PATCH 5/5] Turn Products folder into normal group that won't disappear --- Vienna.xcodeproj/project.pbxproj | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Vienna.xcodeproj/project.pbxproj b/Vienna.xcodeproj/project.pbxproj index 72458535cd..81660372d0 100644 --- a/Vienna.xcodeproj/project.pbxproj +++ b/Vienna.xcodeproj/project.pbxproj @@ -709,7 +709,7 @@ 035B703519E0E4AE00197334 /* Vienna Tests.xctest */, ); name = Products; - sourceTree = SOURCE_ROOT; + sourceTree = BUILT_PRODUCTS_DIR; }; 2A37F4AAFDCFA73011CA2CEA /* Vienna */ = { isa = PBXGroup; @@ -720,9 +720,9 @@ 035B703619E0E4AE00197334 /* Vienna Tests */, F636FEBB2A39031B002AD931 /* Packages */, F63B7D701F1CD001002F71BF /* External */, - 19C28FB0FE9D524F11CA2CBB /* Products */, 439824171666B31700FFE219 /* Scripts */, F6BD1FD72C9D7D9D0075D04F /* Configs */, + 19C28FB0FE9D524F11CA2CBB /* Products */, ); indentWidth = 4; name = Vienna; @@ -1487,7 +1487,6 @@ F69255982572A32900D387D8 /* XCRemoteSwiftPackageReference "MMTabBarView" */, F696D23C2561F9FC003DF0C0 /* XCRemoteSwiftPackageReference "Sparkle" */, ); - productRefGroup = 19C28FB0FE9D524F11CA2CBB /* Products */; projectDirPath = ""; projectRoot = ""; targets = (