Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remark / Rehype are moving entirely to ESM #93

Open
NullVoxPopuli opened this issue May 4, 2021 · 9 comments
Open

Remark / Rehype are moving entirely to ESM #93

NullVoxPopuli opened this issue May 4, 2021 · 9 comments

Comments

@NullVoxPopuli
Copy link
Contributor

what does this mean for docfy and docfy config files?

@josemarluedke
Copy link
Owner

Do you have any resources about this change? We will need to investigate. Probably will restrict what node versions are compatible at least.

@NullVoxPopuli
Copy link
Contributor Author

Just this thread: wooorm/lowlight#37 (comment)

@wooorm
Copy link

wooorm commented May 8, 2021

unifiedjs/unified#121

@NullVoxPopuli
Copy link
Contributor Author

I had forgotten about this, but was reminded during this discussion when I tried to upgrade to hljs@11

remarkjs/remark-highlight.js#38 (comment)

@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented Jun 21, 2021

it's currently not possible to use hljs@11 with remark-highlight.js atm :(

@josemarluedke
Copy link
Owner

@NullVoxPopuli have you seen how the move to ESM affects Docfy?

Regarding highlight, it seems we should be using rehype-highlight moving forward. Have you had success using it?

@NullVoxPopuli
Copy link
Contributor Author

ESM affects Docfy?

once all the dependencies are updated, things should "just work"? (though, seems like there must be a switch to rehype)

Have you had success using it?

haven't tried yet, because I've been waiting for all the dependencies to switch to hljs@11 support

@NullVoxPopuli
Copy link
Contributor Author

Is it time for upgrades? looks like rehype-highlight and all sub-deps are using hljs v11
which means we can have hifi glimmer highlighting!!! :D

@josemarluedke
Copy link
Owner

@NullVoxPopuli I think we should try to upgrade yes. It would be awesome to get the new features. Any change you have cycles to get that going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants