Update ServiceContainer.php #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant issue in parent repo: jonnnnyw#216 Declaration of JonnyW\..\ServiceContainer::load() should be compatible with Symfony\..\Container::load($file)
|
+1 |
|
Please merge this |
dimanise
added a commit
to dimanise/php-phantomjs
that referenced
this pull request
Feb 17, 2018
Fix as per jonnnnyw#235
dimanise
added a commit
to dimanise/php-phantomjs
that referenced
this pull request
Feb 17, 2018
BR0kEN-
suggested changes
Mar 7, 2018
composer.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "jonnyw/php-phantomjs", | |||
| "description": "A PHP wrapper for loading pages through PhantomJS", | |||
| "name": "cocostru/php-phantomjs", | |||
There was a problem hiding this comment.
You should remove this and similar modifications in order to consider merge of this PR.
composer.json
Outdated
| @@ -9,6 +9,11 @@ | |||
| "name": "Jonny Wenmoth", | |||
| "email": "[email protected]", | |||
| "homepage": "http://jonnyw.me/" | |||
| }, | |||
| { | |||
| "name": "Denis Kostukovic", | |||
There was a problem hiding this comment.
Should be removed before merging to the main repository.
|
Please merge this. php-phantomjs is broken without it. |
|
I've sent a tweet to the author to see if he'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#216
#217
#222
#225
#231
#232
#247
#259
#275