Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Body on Scan - Metallic Ring #136

Closed
Sporkley opened this issue Oct 13, 2020 · 2 comments · Fixed by #137
Closed

Missing Body on Scan - Metallic Ring #136

Sporkley opened this issue Oct 13, 2020 · 2 comments · Fixed by #137

Comments

@Sporkley
Copy link

Possibly a duplicate of #105 but I noticed that when I scanned a planet with FSS it didn't appear in EDScout. All other bodies are responding and updating fine. Notably the planet in question has a metallic ring, and is the only metallic ring planet I've scanned so far with the latest version (1.7.1.0).

After digging into the code I notice your switch statement appears to be looking for eRingClass_Metallic, but in the scans Metallic is actually misspelled as "Metalic". Here is the scan in question:

{ "timestamp":"2020-10-13T21:34:30Z", "event":"Scan", "ScanType":"Detailed", "BodyName":"Sleguae AN-M c23-4 A 2", "BodyID":22, "Parents":[ {"Null":21}, {"Star":1}, {"Null":0} ], "StarSystem":"Sleguae AN-M c23-4", "SystemAddress":1178599166154, "DistanceFromArrivalLS":1614.812718, "TidalLock":false, "TerraformState":"", "PlanetClass":"Sudarsky class III gas giant", "Atmosphere":"", "AtmosphereComposition":[ { "Name":"Hydrogen", "Percent":73.104919 }, { "Name":"Helium", "Percent":26.895090 } ], "Volcanism":"", "MassEM":1664.134521, "Radius":74779944.000000, "SurfaceGravity":118.611691, "SurfaceTemperature":393.255524, "SurfacePressure":0.000000, "Landable":false, "SemiMajorAxis":794658607.244492, "Eccentricity":0.033201, "OrbitalInclination":-7.229987, "Periapsis":249.203960, "OrbitalPeriod":8435987.770557, "RotationPeriod":212952.984035, "AxialTilt":-0.975308, "Rings":[ { "Name":"Sleguae AN-M c23-4 A 2 A Ring", "RingClass":"eRingClass_Metalic", "MassMT":1.525e+11, "InnerRad":1.1955e+08, "OuterRad":1.3837e+08 }, { "Name":"Sleguae AN-M c23-4 A 2 B Ring", "RingClass":"eRingClass_MetalRich", "MassMT":4.7453e+12, "InnerRad":1.3847e+08, "OuterRad":4.1255e+08 } ], "ReserveLevel":"PristineResources", "WasDiscovered":false, "WasMapped":false }
@joncage
Copy link
Owner

joncage commented Oct 13, 2020

Good spot! This is not a duplicate but a new bug. Thanks 👍

@joncage
Copy link
Owner

joncage commented Oct 13, 2020

Sure enough, replaying that I get:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants