-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The indexer does not use the IndexNameMapper #168
Comments
Thanks for the report. Do you want to give it a try? |
What is your goto ? Using the indexNameMapper everywhere ? Along with the issue reported by @Nek- , one consequence is that I see no way as for now to retrieve dynamically The IndexNameMapper contains several methods to return a prefixed index name based on a class, but no way to retrieve non-prefixed index name. And since the I could take a look at it but I'd like to know the exact scope of it, since this seems to be a BC break. |
You are supposed to call Client->getIndex() to get a Index. Line 57 in 2a97fc8
That means you should now the that Class FOO belong to index "yop". If your application does not have this information, you could expose the config elsewhere: elastically/tests/Symfony/config.yaml Lines 45 to 46 in 2a97fc8
Or maybe we should add a helper in the Client, like "getIndexFromObject"? Would that help? |
Because the IndexNameMapper does not use the indexNameMapper, the prefix is never added to the index name. However, the IndexBuilder is using it and works with the prefix! It's highly disturbing.
elastically/src/Indexer.php
Line 45 in 96a52d1
The text was updated successfully, but these errors were encountered: