fix: NullableTransformer
should check if array key exists
#7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when mapping from array to an object, if a property is nullable and is not present in the original object, there should be no error if the property defaults to null.
currently, this code:
generates the following code:
and results in an error where
foo
key does not exist, although we provided a default error.At first, I wanted to add an
isset()
only if the property has a default value, but it appears that it is a little bit complex:NullableTransformerFactory
would need to access to property info to get the write info of the property... I think this would be overkill for the case where the property is nullable and adding aisset()
everywhere we have a array access is enough and not harmful.