Update to 1.16.100 protocol and change up some usages and phpdocs #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw I think your Travis is broken because apparently your script says the file exists, but curl won't connect so it exits |
|
Good Job |
|
BTW for a working safe download heres the poggit link |
|
Any chance to have it updated soon ? |
|
Thats not dependent on me ask Joe Joe that question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
I've added the newest protocol version (419) to the required api array in the Plugin.yml
I've also fixed up some phpdocs that weren't formatted or fully finished in the phpstan format
I also changed the way the SlapperEntities are registered to a method of reading files and making the namespace based off the file names