Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Github plugin #72

Closed
2 tasks
johnmaguire opened this issue Sep 9, 2015 · 4 comments
Closed
2 tasks

Create a Github plugin #72

johnmaguire opened this issue Sep 9, 2015 · 4 comments

Comments

@johnmaguire
Copy link
Owner

Features:

  • Notify of new commits / issues / pull requests
  • Ability to quickly link to issues (e.g. ".issue 12" or ".issue web UI")
@s-ol
Copy link
Contributor

s-ol commented Nov 9, 2015

How do I write an plugin that has it's own event loop / listens for github updates?

@s-ol s-ol mentioned this issue Nov 10, 2015
@s-ol
Copy link
Contributor

s-ol commented Nov 10, 2015

This issue will automatically be closed if you merge #78

@johnmaguire
Copy link
Owner Author

Regarding listening for Github updates, my plan is to create a "web" plugin (#58) that would allow Github to call a webhook on it. I wanted to avoid forking / threading each plugin in Cardinal (i.e. allowing them to run an event loop.)

I'm not sure this is the most valid approach, but I have ideas on the web plugin being extensible in other ways as well (i.e. #71)

@johnmaguire
Copy link
Owner Author

This is awesome! Just made a couple tweaks for consistency. Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants