Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbering for chapters and notebooks discrepancy #186

Open
kfahn22 opened this issue Jan 16, 2024 · 3 comments
Open

Numbering for chapters and notebooks discrepancy #186

kfahn22 opened this issue Jan 16, 2024 · 3 comments

Comments

@kfahn22
Copy link
Contributor

kfahn22 commented Jan 16, 2024

There is a difference in how chapter number / ordering of the notebook folders -- I am not sure if it matters.

notebooks chapters
@snehilsanyal
Copy link
Contributor

I think it won't matter after doc building, as the filesystem is sorted in this manner: 1, 10, 11, 12, 13, 2
This can be avoided if we use leading zeroes for all single units like 01, 02, 03 ....

@kfahn22
Copy link
Contributor Author

kfahn22 commented Jan 17, 2024

It wasn't the order that I was concerned about, but the numbering. Synthetic data creation is Unit 10 in chapters and Unit 11 in the folders for notebooks. I just don't know if that matters.

@johko
Copy link
Owner

johko commented Jan 21, 2024

oh, well I think it should be the same. Can you create a PR to fix it @kfahn22 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants