This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Simple querySelectorAll command-770156 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the feedback, I've made most of the changes except for the tests, which I'll have a look at later. |
Simple querySelectorAll (`qsa`) command added to gcli. The command takes a string parameter which will be run as a css selector. Matching nodes will be displayed. Nodes can then be clicked. When clicked, a unique CSS selector will be calculated for the given node and `qsa` will be run again with that selector. The command simply uses document.querySelectorAll in its exec method. The view is done via a converter. Signed-off-by: Patrick Brosset <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clean-up of PR https://github.com/mozilla/gcli/pull/64
Please see my comments there.
Thanks
Patrick