AngularJS Style Guide

Adapted from Opinionated AngularJS style guide for teams by John Papa and Todd Motto

See the Styles in a Sample App

Would be nice to create sample app based on our style guide. May just include sample files...

##Styles Styles taken from Papa's style guide are labeled: P001, P002, etc. Styles taken from Motto's style guide are labeled M001, M002, etc. Styles that I have added or changed are labeled F001, F002, etc.

Single Responsibility
IIFE
Modules
Controllers
Services
Factories
Data Services
Directives
Resolving Promises for a Controller
Manual Annotating for Dependency Injection
Minification and Annotation
Events
Exception Handling
Naming
Application Structure LIFT Principle
Application Structure
Modularity
Startup Logic
Angular $ Wrapper Services
Testing
Animations
Comments
JSHint
Constants
File Templates and Snippets
AngularJS Docs
Contributing
License

Single Responsibility

Rule of 1

[Style P001]

Define 1 component per file.

The following example defines the app module and its dependencies, defines a controller, and defines a factory all in the same file.

/* avoid */
angular
  	.module('app', ['ngRoute'])
  	.controller('SomeController', SomeController)
  	.factory('someFactory', someFactory);
	
function SomeController() { }

function someFactory() { }

The same components are now separated into their own files.

/* recommended */

// app.module.js
angular
  	.module('app', ['ngRoute']);

/* recommended */

// someController.js
angular
  	.module('app')
  	.controller('SomeController', SomeController);

function SomeController() { }

/* recommended */

// someFactory.js
angular
  	.module('app')
  	.factory('someFactory', function someFactory() { });

Back to top

IIFE

JavaScript Closures

[Style P010]

Wrap AngularJS components in an Immediately Invoked Function Expression (IIFE).

Why?: An IIFE removes variables from the global scope. This helps prevent variables and function declarations from living longer than expected in the global scope, which also helps avoid variable collisions. [JD: Preventing global variables does not seem like a compelling reason given that you could easily solve the same problem by using an in-line function. However, using the IIFE also keeps the 'use strict' from being at the file level, which can cause issues when concatenating files with and without 'use strict'. If all files are 'use strict', this is also not an issue. That said, using an IIFE vs an in-line function is not a big stylistic difference. I do not have a strong opinion on this and find either way easy to read.]

Why?: When your code is minified and bundled into a single file for deployment to a production server, you could have collisions of variables and many global variables. An IIFE protects you against both of these by providing variable scope for each file. [JD: Again I think this makes sense to protect 'use strict' more than anything else.]

/* avoid */
// logger.js
angular
    .module('app')
    .factory('logger', logger);

// logger function is added as a global variable  
function logger() { }

// storage.js
angular
    .module('app')
    .factory('storage', storage);

// storage function is added as a global variable  
function storage() { }

/**
 * recommended 
 *
 * no globals are left behind 
 */

// logger.js
(function() {
    'use strict';
    
    angular
        .module('app')
        .factory('logger', logger);

    function logger() { }
})();

// storage.js
(function() {
    'use strict';

    angular
        .module('app')
        .factory('storage', storage);

    function storage() { }
})();

Note: For brevity only, the rest of the examples in this guide may omit the IIFE syntax.
Note: IIFE's prevent test code from reaching private members like regular expressions or helper functions which are often good to unit test directly on their own. However you can test these through accessible members or by exposing them through their own component. For example placing helper functions, regular expressions or constants in their own factory or constant.

Back to top

Modules

Avoid Naming Collisions

[Style P020]

Use unique naming conventions with separators for sub-modules.

Why?: Unique names help avoid module name collisions. Separators help define modules and their submodule hierarchy. For example app may be your root module while app.dashboard and app.users may be modules that are used as dependencies of app.

Definitions (aka Setters)

[Style P021]

Declare modules without a variable using the setter syntax.

Why?: With 1 component per file, there is rarely a need to introduce a variable for the module.

/* avoid */
var app = angular.module('app', [
    'ngAnimate',
    'ngRoute',
    'app.shared',
    'app.dashboard'
]);

Instead use the simple setter syntax.

/* recommended */
angular
  	.module('app', [
        'ngAnimate',
        'ngRoute',
        'app.shared',
        'app.dashboard'
    ]);

Getters

[Style P022]

When using a module, avoid using a variable and instead use chaining with the getter syntax.

Why? : This produces more readable code and avoids variable collisions or leaks.

/* avoid */
var app = angular.module('app');
app.controller('SomeController', SomeController);

function SomeController() { }

/* recommended */
angular
    .module('app')
    .controller('SomeController', SomeController);

function SomeController() { }

Setting vs Getting

[Style P023]

Only set once and get for all other instances.

Why?: A module should only be created once, then retrieved from that point and after.
- Use angular.module('app', []); to set a module.
- Use angular.module('app'); to get a module.

Named vs Anonymous Functions

[Style P024]

Use named functions instead of passing an anonymous function in as a callback.

Why?: This produces more readable code, is much easier to debug, and reduces the amount of nested callback code.

/* avoid */
angular
    .module('app')
    .controller('Dashboard', function() { })
    .factory('logger', function() { });

/* recommended */

// dashboard.js
angular
    .module('app')
    .controller('Dashboard', Dashboard);

function Dashboard() { }

// logger.js
angular
    .module('app')
    .factory('logger', logger);

function logger() { }

// logger.js
angular
    .module('app')
    .factory('logger', function logger() { });

Back to top

Controllers

controllerAs View Syntax

[Style P030]

Use the controllerAs syntax over the classic controller with $scope syntax.

Why?: Controllers are constructed, "newed" up, and provide a single new instance, and the controllerAs syntax is closer to that of a JavaScript constructor than the classic $scope syntax.

Why?: It promotes the use of binding to a "dotted" object in the View (e.g. customer.name instead of name), which is more contextual, easier to read, and avoids any reference issues that may occur without "dotting".

Why?: Helps avoid using $parent calls in Views with nested controllers.

<!-- avoid -->
<div ng-controller="Customer">
    {{ name }}
</div>

<!-- recommended -->
<div ng-controller="Customer as customer">
   {{ customer.name }}
</div>

controllerAs Controller Syntax

[Style P031]

Use the controllerAs syntax over the classic controller with $scope syntax.
The controllerAs syntax uses this inside controllers which gets bound to $scope

Why?: controllerAs is syntactic sugar over $scope. You can still bind to the View and still access $scope methods.

Why?: Helps avoid the temptation of using $scope methods inside a controller when it may otherwise be better to avoid them or move them to a factory. Consider using $scope in a factory, or if in a controller just when needed. For example when publishing and subscribing events using $emit, $broadcast, or $on consider moving these uses to a factory and invoke from the controller.
NOTE: If you move $emit, $broadcast, $on, or $watch from a controller to a service, you must make sure you de-register these events/watchers. In the controller, they automatically get removed when the controller's $scope is destroyed. However, services do not get removed, so the events will continue to be executed. At best this a performance issue. Quite possibly it will cause unintended affects.

/* avoid */
function Customer($scope) {
    $scope.name = {};
    $scope.sendMessage = function() { };
}

/* recommended - but see next section */
function Customer() {
    this.name = {};
    this.sendMessage = function() { };
}

controllerAs with capture variable

[Style F032]

Use a capture variable for this when using the controllerAs syntax. Use the same name as the controller.

Why?: The this keyword is contextual and when used within a function inside a controller may change its context. Capturing the context of this avoids encountering this problem.

Why?: While using a consistent name such as "vm" is common practice (both Papa and Motto styleguides suggest using 'vm'), using the same name as the controller allows search across files to find all references to methods and properties associated with the controller.

/* avoid */
function Customer() {
    this.name = {};
    this.sendMessage = function() { };
}

/* recommended */
function Customer() {
    var Customer = this;
    Customer.name = {};
    Customer.sendMessage = function() { };
}

Note: You can avoid any jshint warnings by placing the comment below above the line of code. However it is not needed when the function is named using UpperCasing, as this convention means it is a constructor function, which is what a controller is in Angular.

/* jshint validthis: true */
var Customer = this;

Note: When creating watches in a controller using controller as, you can watch the vm.* member using the following syntax. (Create watches with caution as they add more load to the digest cycle.)

$scope.$watch('Customer.title', function(current, original) {
    $log.info('Customer.title was %s', original);
    $log.info('Customer.title is now %s', current);
});

Bindable Members Up Top

[Style P033]

Place bindable members at the top of the controller, ~~alphabetized~~, and not spread through the controller code.

Why?: Placing bindable members at the top makes it easy to read and helps you instantly identify which members of the controller can be bound and used in the View.

Why?: Setting anonymous functions in-line can be easy, but when those functions are more than 1 line of code they can reduce the readability. Defining the functions below the bindable members (the functions will be hoisted) moves the implementation details down, keeps the bindable members up top, and makes it easier to read.

/* avoid */
function Sessions() {
    var Sessions = this;

    Sessions.gotoSession = function() {
      /* ... */
    };
    Sessions.refresh = function() {
      /* ... */
    };
    Sessions.search = function() {
      /* ... */
    };
    Sessions.sessions = [];
    Sessions.title = 'Sessions';

/* recommended */
function Sessions() {
    var Sessions = this;

    Sessions.gotoSession = gotoSession;
    Sessions.refresh = refresh;
    Sessions.search = search;
    Sessions.sessions = [];
    Sessions.title = 'Sessions';

    ////////////

    function gotoSession() {
      /* */
    }

    function refresh() {
      /* */
    }

    function search() {
      /* */
    }

Note: If the function is a 1 liner consider keeping it right up top, as long as readability is not affected.

/* avoid */
function Sessions(data) {
    var Sessions = this;

    Sessions.gotoSession = gotoSession;
    Sessions.refresh = function() {
        /** 
         * lines 
         * of
         * code
         * affects
         * readability
         */
    };
    Sessions.search = search;
    Sessions.sessions = [];
    Sessions.title = 'Sessions';

/* recommended */
function Sessions(dataservice) {
    var Sessions = this;

    Sessions.gotoSession = gotoSession;
    Sessions.refresh = dataservice.refresh; // 1 liner is OK
    Sessions.search = search;
    Sessions.sessions = [];
    Sessions.title = 'Sessions';

Function Declarations to Hide Implementation Details

[Style P034]

Use function declarations to hide implementation details. Keep your bindable members up top. When you need to bind a function in a controller, point it to a function declaration that appears later in the file. This is tied directly to the section Bindable Members Up Top. For more details see this post. This is a fine practice, but is not necessary. There are pros and cons.

Why?: Placing bindable members at the top makes it easy to read and helps you instantly identify which members of the controller can be bound and used in the View. (Same as above.)

Why?: Placing the implementation details of a function later in the file moves that complexity out of view so you can see the important stuff up top. BUT, this also makes it harder to reason about. There is now an extra level of indirection when you are reasoning or debugging the code. Which do you do more often? Look at a service/controller and ask "What functions does this service/controller expose?" or look at a particular function in a service/controller and ask "What does this funciton do?" If it's the latter, then this practice actually makes things more difficult.

Why?: Function declaration are hoisted so there are no concerns over using a function before it is defined (as there would be with function expressions). BUT, still causes problems if you are using jshint, so you are back in the same boat of putting the function declarations first anyway.

Why?: You never have to worry with function declarations that moving var a before var b will break your code because a depends on b. However, this is not an issue with services/controllers anyway since they get created before any functions are called.

Why?: Order is critical with function expression.

This is not something we have a strong preference on one way or another. There are good reasons for doing it either way. Ultimately, it's much more important to focus on keeping controllers skinny and putting business logic in services. Doing so will not only address this issue, but will provide benefits of making business logic reusable, more testable, and more easily upgraded. (see next section Defer Controller Logic)

Defer Controller Logic

[Style P035]

Defer logic in a controller by delegating to services and factories.

Why?: Logic may be reused by multiple controllers when placed within a service and exposed via a function.

Why?: Logic in a service can more easily be isolated in a unit test, while the calling logic in the controller can be easily mocked.

Why?: Removes dependencies and hides implementation details from the controller.

Why?: Makes upgrading to AngularJS 2.0 easier. [JD]

/* avoid */
function OrderCtrl($http, $q) {
    var OrderCtrl = this;
    OrderCtrl.checkCredit = checkCredit;
    OrderCtrl.total = 0;

    function checkCredit() { 
        var orderTotal = OrderCtrl.total;
        return $http.get('api/creditcheck').then(function(data) {
            var remaining = data.remaining;
            return $q.when(!!(remaining > orderTotal));
        });
    };
}

/* recommended */
function OrderCtrl(creditService) {
    var OrderCtrl = this;
    OrderCtrl.checkCredit = checkCredit;
    OrderCtrl.total = 0;

    function checkCredit() { 
       return creditService.check();
    };
}

Keep Controllers Focused

[Style P037]

Define a controller for a view, and try not to reuse the controller for other views. Instead, move reusable logic to factories and keep the controller simple and focused on its view.

Why?: Reusing controllers with several views is brittle and good end to end (e2e) test coverage is required to ensure stability across large applications.

Assigning Controllers

[Style P038]

When a controller must be paired with a view and either component may be re-used by other controllers or views, define controllers along with their routes.

Note: If a View is loaded via another means besides a route, then use the ng-controller="Avengers as Avengers" syntax.

Why?: Pairing the controller in the route allows different routes to invoke different pairs of controllers and views. When controllers are assigned in the view using ng-controller, that view is always associated with the same controller.

 /* avoid - when using with a route and dynamic pairing is desired */

 // route-config.js
 angular
     .module('app')
     .config(config);

 function config($routeProvider) {
     $routeProvider
         .when('/avengers', {
           templateUrl: 'avengers.html'
         });
 }

<!-- avengers.html -->
<div ng-controller="Avengers as Avengers">
</div>

/* recommended */

// route-config.js
angular
    .module('app')
    .config(config);

function config($routeProvider) {
    $routeProvider
        .when('/avengers', {
            templateUrl: 'avengers.html',
            controller: 'Avengers',
            controllerAs: 'Avengers'
        });
}

<!-- avengers.html -->
<div>
</div>

Back to top

Services

Singletons

[Style Y040]

~~Services are instantiated with the new keyword, use this for public methods and variables.~~ Use a capture variable with the same name as the service or factory.

Why?: Allows searching across files to find all instances of properties and functions for the service. Protects against this changing during run time in function (usually only a problem for events, timers, intervals, etc.).

~~Since these are so similar to factories, use a factory instead for consistency.~~A service is just a special case of factory. Use of either one is fine. We do not make a distinction in naming, however, since it is an implementation detail. We always refer to them as services.

Note: [All AngularJS services are singletons](https://docs.angularjs.org/guide/services). This means that there is only one instance of a given service per injector.

// service
angular
    .module('app')
    .service('logger', logger);

function logger() {
    var logger = this;
    logger.logError = function(msg) {
      /* */
    };
}

// factory
angular
    .module('app')
    .factory('logger', logger);

function logger() {
    var logger = {};
    
    logger.logError: function(msg) {
          /* */
    }
    
    return logger;     
}

Back to top

Factories

Single Responsibility

[Style Y050]

Factories should have a single responsibility, that is encapsulated by its context. Once a factory begins to exceed that singular purpose, a new factory should be created.

Singletons

[Style Y051]

Factories are singletons and return an object that contains the members of the service.

Note: All AngularJS services are singletons.

###Always return a host Object

[Style T001]

Why?: Always return a host Object instead of the revealing Module pattern due to the way Object references are bound and updated. Primitive values cannot update alone using the revealing module pattern. NOTE: Use of function declaration vs function variables is irrelevant. Either way is OK. The point of this example is to avoid use the revealing Module pattern.

/* avoid */
function dataService() {
    var someValue = '';
    var service = {
        save: save,
        someValue: someValue,
        validate: validate
    };
    return service;

    ////////////

    function save() {
        /* */
    };

    function validate() {
        /* */
    };
}

/* recommended */
function dataService() {
    var dataService = {}
    dataService.someValue = '';

    dataService.save = function() {
        /* */
    };

    dataService.validate = function() {
        /* */
    };
    
    return dataService;
}

Back to top

Data Services

Separate Data Calls

[Style P060]

Refactor logic for making data operations and interacting with data to a factory. Make data services responsible for XHR calls, local storage, stashing in memory, or any other data operations.

Why?: The controller's responsibility is for the presentation and gathering of information for the view. It should not care how it gets the data, just that it knows who to ask for it. Separating the data services moves the logic on how to get it to the data service, and lets the controller be simpler and more focused on the view.

Why?: This makes it easier to test (mock or real) the data calls when testing a controller that uses a data service.

Why?: Data service implementation may have very specific code to handle the data repository. This may include headers, how to talk to the data, or other services such as $http. Separating the logic into a data service encapsulates this logic in a single place hiding the implementation from the outside consumers (perhaps a controller), also making it easier to change the implementation.

/* recommended */

// dataservice factory
angular
    .module('app.core')
    .factory('dataservice', dataservice);

dataservice.$inject = ['$http', 'logger'];

function dataservice($http, logger) {
    var dataService = {};     

    dataService.getAvengers = function() {
        return $http.get('/api/maa')
            .then(getAvengersComplete)
            .catch(getAvengersFailed);

        function getAvengersComplete(response) {
            return response.data.results;
        }

        function getAvengersFailed(error) {
            logger.error('XHR Failed for getAvengers.' + error.data);
        }
    };

    return dataService;
}

Note: The data service is called from consumers, such as a controller, hiding the implementation from the consumers, as shown below.

/* recommended */

// controller calling the dataservice factory
angular
    .module('app.avengers')
    .controller('Avengers', Avengers);

Avengers.$inject = ['dataservice', 'logger'];

function Avengers(dataservice, logger) {
    var Avengers = this;
    Avengers.avengers = [];

    activate();

    function activate() {
        return getAvengers().then(function() {
            logger.info('Activated Avengers View');
        });
    }

    function getAvengers() {
        return dataservice.getAvengers()
            .then(function(data) {
                Avengers.avengers = data;
                return Avengers.avengers;
            });
    }
}

Return a Promise from Data Calls

[Style P061]

When calling a data service that returns a promise such as $http, return a promise in your calling function too.

Why?: You can chain the promises together and take further action after the data call completes and resolves or rejects the promise.

/* recommended */

activate();

function activate() {
    /**
     * Step 1
     * Ask the getAvengers function for the
     * avenger data and wait for the promise
     */
    return getAvengers().then(function() {
        /**
         * Step 4
         * Perform an action on resolve of final promise
         */
        logger.info('Activated Avengers View');
    });
}

function getAvengers() {
      /**
       * Step 2
       * Ask the data service for the data and wait
       * for the promise
       */
      return dataservice.getAvengers()
          .then(function(data) {
              /**
               * Step 3
               * set the data and resolve the promise
               */
              Avengers.avengers = data;
              return Avengers.avengers;
      });
}

**[Back to top](#table-of-contents)**

Directives

Limit 1 Per File

[Style P070]

Create one directive per file. Name the file for the directive.

Why?: It is easy to mash all the directives in one file, but difficult to then break those out so some are shared across apps, some across modules, some just for one module.

Why?: One directive per file is easy to maintain.

/* avoid */
/* directives.js */

angular
    .module('app.widgets')

    /* order directive that is specific to the order module */
    .directive('orderCalendarRange', orderCalendarRange)

    /* sales directive that can be used anywhere across the sales app */
    .directive('salesCustomerInfo', salesCustomerInfo)

    /* spinner directive that can be used anywhere across apps */
    .directive('sharedSpinner', sharedSpinner);


function orderCalendarRange() {
    /* implementation details */
}

function salesCustomerInfo() {
    /* implementation details */
}

function sharedSpinner() {
    /* implementation details */
}

/* recommended */
/* calendarRange.directive.js */

/**
 * @desc order directive that is specific to the order module at a company named Acme
 * @example <div acme-order-calendar-range></div>
 */
angular
    .module('sales.order')
    .directive('acmeOrderCalendarRange', orderCalendarRange);

function orderCalendarRange() {
    /* implementation details */
}

/* recommended */
/* customerInfo.directive.js */

/**
 * @desc spinner directive that can be used anywhere across the sales app at a company named Acme
 * @example <div acme-sales-customer-info></div>
 */    
angular
    .module('sales.widgets')
    .directive('acmeSalesCustomerInfo', salesCustomerInfo);

function salesCustomerInfo() {
    /* implementation details */
}

/* recommended */
/* spinner.directive.js */

/**
 * @desc spinner directive that can be used anywhere across apps at a company named Acme
 * @example <div acme-shared-spinner></div>
 */
angular
    .module('shared.widgets')
    .directive('acmeSharedSpinner', sharedSpinner);

function sharedSpinner() {
    /* implementation details */
}

Note: There are many naming options for directives, especially since they can be used in narrow or wide scopes. Choose one that makes the directive and it's file name distinct and clear. Some examples are below, but see the naming section for more recommendations.

Manipulate DOM in a Directive

[Style P072]

When manipulating the DOM directly, use a directive. If alternative ways can be used such as using CSS to set styles or the animation services, Angular templating, ngShow or ngHide, then use those instead. For example, if the directive simply hides and shows, use ngHide/ngShow.

Why?: DOM manipulation can be difficult to test, debug, and there are often better ways (e.g. CSS, animations, templates)

Provide a Unique Directive Prefix - fss?

[Style P073]

Provide a short, unique and descriptive directive prefix such as acmeSalesCustomerInfo which is declared in HTML as acme-sales-customer-info.

Why?: The unique short prefix identifies the directive's context and origin. For example a prefix of cc- may indicate that the directive is part of a CodeCamper app while acme- may indicate a directive for the Acme company.

Note: Avoid ng- as these are reserved for AngularJS directives.Research widely used directives to avoid naming conflicts, such as ion- for the Ionic Framework.

Restrict to Elements and Attributes

[Style Y074]

When creating a directive that makes sense as a standalone element, allow restrict E (custom element) and optionally restrict A (custom attribute). Generally, if it could be its own control, E is appropriate. General guideline is allow EA but lean towards implementing as an element when its standalone and as an attribute when it enhances its existing DOM element.

Why?: It makes sense.

Why?: While we can allow the directive to be used as a class, if the directive is truly acting as an element it makes more sense as an element or at least as an attribute.

Note: EA is the default for AngularJS 1.3 +

<!-- avoid -->
<div class="my-calendar-range"></div>

/* avoid */
angular
    .module('app.widgets')
    .directive('myCalendarRange', myCalendarRange);

function myCalendarRange() {
    var directive = {
        link: link,
        templateUrl: '/template/is/located/here.html',
        restrict: 'C'
    };
    return directive;

    function link(scope, element, attrs) {
      /* */
    }
}

<!-- recommended -->
<my-calendar-range></my-calendar-range>
<div my-calendar-range></div>

/* recommended */
angular
    .module('app.widgets')
    .directive('myCalendarRange', myCalendarRange);

function myCalendarRange() {
    var directive = {
        link: link,
        templateUrl: '/template/is/located/here.html',
        restrict: 'EA'
    };
    return directive;

    function link(scope, element, attrs) {
      /* */
    }
}

Directives and ControllerAs

[Style Y075]

Use controller as syntax with a directive to be consistent with using controller as with view and controller pairings.

Why?: It makes sense and it's not difficult.

Note: The directive below demonstrates some of the ways you can use scope inside of link and directive controllers, using controllerAs. I in-lined the template just to keep it all in one place.

Note: Regarding dependency injection, see Manually Identify Dependencies.

Note: Note that the directive's controller is outside the directive's closure. This style eliminates issues where the injection gets created as unreachable code after a return.

<div my-example max="77"></div>

angular
    .module('app')
    .directive('myExample', myExample);

function myExample() {
    var directive = {
        restrict: 'EA',
        templateUrl: 'app/feature/example.directive.html',
        scope: {
            max: '='
        },
        link: linkFunc,
        controller : ExampleController,
        controllerAs: 'vm'
    };
    
    return directive;

    function linkFunc(scope, el, attr, ctrl) {
        console.log('LINK: scope.max = %i', scope.max);
        console.log('LINK: scope.vm.min = %i', scope.vm.min);
        console.log('LINK: scope.vm.max = %i', scope.vm.max);
    }
}

ExampleController.$inject = ['$scope'];

function ExampleController($scope) {
    // Injecting $scope just for comparison
    var vm = this;

    vm.min = 3; 
    vm.max = $scope.max; 
    console.log('CTRL: $scope.max = %i', $scope.max);
    console.log('CTRL: vm.min = %i', vm.min);
    console.log('CTRL: vm.max = %i', vm.max);
}

/* example.directive.html */
<div>hello world</div>
<div>max={{vm.max}}<input ng-model="vm.max"/></div>
<div>min={{vm.min}}<input ng-model="vm.min"/></div>

Back to top

Resolving Promises for a Controller

Controller Activation Promises

[Style Y080]

Resolve start-up logic for a controller in an activate function.

Why?: Placing start-up logic in a consistent place in the controller makes it easier to locate, more consistent to test, and helps avoid spreading out the activation logic across the controller.

Note: If you need to conditionally cancel the route before you start use the controller, use a route resolve instead.

/* avoid */
function Avengers(dataservice) {
    var vm = this;
    vm.avengers = [];
    vm.title = 'Avengers';

    dataservice.getAvengers().then(function(data) {
        vm.avengers = data;
        return vm.avengers;
    });
}

/* recommended */
function Avengers(dataservice) {
    var vm = this;
    vm.avengers = [];
    vm.title = 'Avengers';

    activate();

    ////////////

    function activate() {
        return dataservice.getAvengers().then(function(data) {
            vm.avengers = data;
            return vm.avengers;
        });
    }
}

Route Resolve Promises

[Style Y081]

When a controller depends on a promise to be resolved, resolve those dependencies in the $routeProvider before the controller logic is executed. If you need to conditionally cancel a route before the controller is activated, use a route resolver.

Why?: A controller may require data before it loads. That data may come from a promise via a custom factory or $http. Using a route resolve allows the promise to resolve before the controller logic executes, so it might take action based on that data from the promise.

/* avoid */
angular
    .module('app')
    .controller('Avengers', Avengers);

function Avengers(movieService) {
    var vm = this;
    // unresolved
    vm.movies;
    // resolved asynchronously
    movieService.getMovies().then(function(response) {
        vm.movies = response.movies;
    });
}

/* better */

// route-config.js
angular
    .module('app')
    .config(config);

function config($routeProvider) {
    $routeProvider
        .when('/avengers', {
            templateUrl: 'avengers.html',
            controller: 'Avengers',
            controllerAs: 'vm',
            resolve: {
                moviesPrepService: function(movieService) {
                    return movieService.getMovies();
                }
            }
        });
}

// avengers.js
angular
    .module('app')
    .controller('Avengers', Avengers);

Avengers.$inject = ['moviesPrepService'];
function Avengers(moviesPrepService) {
      var vm = this;
      vm.movies = moviesPrepService.movies;
}

Note: The code example's dependency on `movieService` is not minification safe on its own. For details on how to make this code minification safe, see the sections on [dependency injection](#manual-annotating-for-dependency-injection) and on [minification and annotation](#minification-and-annotation).

Back to top

Manual Annotating for Dependency Injection

UnSafe from Minification

[Style Y090]

Avoid using the shortcut syntax of declaring dependencies without using a minification-safe approach.

Why?: The parameters to the component (e.g. controller, factory, etc) will be converted to mangled variables. For example, common and dataservice may become a or b and not be found by AngularJS.
```
/* avoid - not minification-safe*/
angular
    .module('app')
    .controller('Dashboard', Dashboard);

function Dashboard(common, dataservice) {
}
```
This code may produce mangled variables when minified and thus cause runtime errors.
```
/* avoid - not minification-safe*/
angular.module('app').controller('Dashboard', d);function d(a, b) { }
```

Manually Identify Dependencies

[Style Y091]

Use $inject to manually identify your dependencies for AngularJS components.

Why?: This technique mirrors the technique used by ng-annotate, which I recommend for automating the creation of minification safe dependencies. If ng-annotate detects injection has already been made, it will not duplicate it.

Why?: This safeguards your dependencies from being vulnerable to minification issues when parameters may be mangled. For example, common and dataservice may become a or b and not be found by AngularJS.

Why?: Avoid creating in-line dependencies as long lists can be difficult to read in the array. Also it can be confusing that the array is a series of strings while the last item is the component's function.

/* avoid */
angular
    .module('app')
    .controller('Dashboard', 
        ['$location', '$routeParams', 'common', 'dataservice', 
            function Dashboard($location, $routeParams, common, dataservice) {}
        ]);

/* avoid */
angular
  .module('app')
  .controller('Dashboard', 
     ['$location', '$routeParams', 'common', 'dataservice', Dashboard]);
  
function Dashboard($location, $routeParams, common, dataservice) {
}

/* recommended */
angular
    .module('app')
    .controller('Dashboard', Dashboard);

Dashboard.$inject = ['$location', '$routeParams', 'common', 'dataservice'];
  
function Dashboard($location, $routeParams, common, dataservice) {
}

Note: When your function is below a return statement the $inject may be unreachable (this may happen in a directive). You can solve this by either moving the $inject above the return statement or by using the alternate array injection syntax.

Note: ng-annotate 0.10.0 introduced a feature where it moves the $inject to where it is reachable.

// inside a directive definition
function outer() {
    return {
        controller: DashboardPanel,
    };

    DashboardPanel.$inject = ['logger']; // Unreachable
    function DashboardPanel(logger) {
    }
}

// inside a directive definition
function outer() {
    DashboardPanel.$inject = ['logger']; // reachable
    return {
        controller: DashboardPanel,
    };

    function DashboardPanel(logger) {
    }
}

Manually Identify Route Resolver Dependencies

[Style Y092]

Use $inject to manually identify your route resolver dependencies for AngularJS components.

Why?: This technique breaks out the anonymous function for the route resolver, making it easier to read.

Why?: An $inject statement can easily precede the resolver to handle making any dependencies minification safe.

/* recommended */
function config($routeProvider) {
    $routeProvider
        .when('/avengers', {
            templateUrl: 'avengers.html',
            controller: 'Avengers',
            controllerAs: 'vm',
            resolve: {
                moviesPrepService: moviePrepService
            }
        });
}

moviePrepService.$inject =  ['movieService'];
function moviePrepService(movieService) {
    return movieService.getMovies();
}

Back to top

Minification and Annotation

ng-annotate

[Style Y100]

Use ng-annotate for Gulp or Grunt and comment functions that need automated dependency injection using /** @ngInject */

Why?: This safeguards your code from any dependencies that may not be using minification-safe practices.

Why?: ng-min is deprecated

I prefer Gulp as I feel it is easier to write, to read, and to debug.

The following code is not using minification safe dependencies.

angular
    .module('app')
    .controller('Avengers', Avengers);

/* @ngInject */
function Avengers(storageService, avengerService) {
    var vm = this;
    vm.heroSearch = '';
    vm.storeHero = storeHero;

    function storeHero(){
        var hero = avengerService.find(vm.heroSearch);
        storageService.save(hero.name, hero);
    }
}

When the above code is run through ng-annotate it will produce the following output with the $inject annotation and become minification-safe.

angular
    .module('app')
    .controller('Avengers', Avengers);

/* @ngInject */
function Avengers(storageService, avengerService) {
    var vm = this;
    vm.heroSearch = '';
    vm.storeHero = storeHero;

    function storeHero(){
        var hero = avengerService.find(vm.heroSearch);
        storageService.save(hero.name, hero);
    }
}

Avengers.$inject = ['storageService', 'avengerService'];

Note: If ng-annotate detects injection has already been made (e.g. @ngInject was detected), it will not duplicate the $inject code.

Note: When using a route resolver you can prefix the resolver's function with /* @ngInject */ and it will produce properly annotated code, keeping any injected dependencies minification safe.

// Using @ngInject annotations
function config($routeProvider) {
    $routeProvider
        .when('/avengers', {
            templateUrl: 'avengers.html',
            controller: 'Avengers',
            controllerAs: 'vm',
            resolve: { /* @ngInject */
                moviesPrepService: function(movieService) {
                    return movieService.getMovies();
                }
            }
        });
}

Note: Starting from AngularJS 1.3 use the ngApp directive's ngStrictDi parameter. When present the injector will be created in "strict-di" mode causing the application to fail to invoke functions which do not use explicit function annotation (these may not be minification safe). Debugging info will be logged to the console to help track down the offending code. <body ng-app="APP" ng-strict-di>

Use Gulp or Grunt for ng-annotate

[Style Y101]

Use gulp-ng-annotate or grunt-ng-annotate in an automated build task. Inject /* @ngInject */ prior to any function that has dependencies.

Why?: ng-annotate will catch most dependencies, but it sometimes requires hints using the /* @ngInject */ syntax.

The following code is an example of a gulp task using ngAnnotate

gulp.task('js', ['jshint'], function() {
    var source = pkg.paths.js;
    return gulp.src(source)
        .pipe(sourcemaps.init())
        .pipe(concat('all.min.js', {newLine: ';'}))
        // Annotate before uglify so the code get's min'd properly.
        .pipe(ngAnnotate({
            // true helps add where @ngInject is not used. It infers.
            // Doesn't work with resolve, so we must be explicit there
            add: true
        }))
        .pipe(bytediff.start())
        .pipe(uglify({mangle: true}))
        .pipe(bytediff.stop())
        .pipe(sourcemaps.write('./'))
        .pipe(gulp.dest(pkg.paths.dev));
});

Back to top

Events

http://eburley.github.io/2013/01/31/angularjs-watch-pub-sub-best-practices.html#best_practices_around_pubsub

Use events when you need to let multiple subscribers know about an event and those subscribers need to do more than radiate information to their view.
Do not use events when you’re watching a simple state based service and using that to update a view.
Do not use events when you’re writing a general purpose directive and need data binding.

[Style F001]

Encapsulate subject-specific watches

Why?: Hides the implementation details of the pub sub. The AngularJS 1.x event system is likely to be different in 2.0 since it is unlikely events would need to be part of the digest cycle. The events could easily be implemented without $scope or Angular.

Why?: It hides the implementation detail of the message text and provides domain specific arguments for the event (e.g., "coreId", "temperature").

/* recommended */
angular
    .module('app.module').service('CoreReactorChannel', ['$rootScope', function($rootScope) {
    var CoreReacto rChannel= this;
	var ELEVATED_CORE_MESSAGE = 'elevated-core-message';

    CoreReactorChannel.elevatedCoreTemperature = function (coreId, temperature) {
	    $rootScope.$broadcast(ELEVATED_CORE_MESSAGE {
			coreId: coreId, 
			temperature: temperature
		});
	};
	
	
	CoreReactorChannel.onElevatedCoreTemperature = function (scope, handler) {
		return scope.$on(ELEVATED_CORE_MESSAGE, function (event, message) {
			handler(message.coreId, message.temperature);
		})
	};
}]);
	
// To use these in a controller or other component..

// Let the CoreReactorChannel know the temperature has changed
CoreReactorChannel.elevatedCoreTemperature(core_id, temperature);

// Listen for temperature changes and call a handler
// Note: The handler can be an inline function
CoreReactorChannel.onElevatedCoreTemperature($scope, onCoreTemperatureChange);

Exception Handling

decorators

[Style Y110]

Use a decorator, at config time using the $provide service, on the $exceptionHandler service to perform custom actions when exceptions occur.

Why?: Provides a consistent way to handle uncaught AngularJS exceptions for development-time or run-time.

Note: Another option is to override the service instead of using a decorator. This is a fine option, but if you want to keep the default behavior and extend it a decorator is recommended.

/* recommended */ angular .module('blocks.exception') .config(exceptionConfig);

exceptionConfig.$inject = ['$provide'];

function exceptionConfig($provide) {
    $provide.decorator('$exceptionHandler', extendExceptionHandler);
}

extendExceptionHandler.$inject = ['$delegate', 'toastr'];

function extendExceptionHandler($delegate, toastr) {
    return function(exception, cause) {
        $delegate(exception, cause);
        var errorData = { 
            exception: exception, 
            cause: cause 
        };
        /**
         * Could add the error to a service's collection,
         * add errors to $rootScope, log errors to remote web server,
         * or log locally. Or throw hard. It is entirely up to you.
         * throw exception;
         */
        toastr.error(exception.msg, errorData);
    };
}
```

Exception Catchers

[Style Y111]

Create a factory that exposes an interface to catch and gracefully handle exceptions.

Why?: Provides a consistent way to catch exceptions that may be thrown in your code (e.g. during XHR calls or promise failures).

Note: The exception catcher is good for catching and reacting to specific exceptions from calls that you know may throw one. For example, when making an XHR call to retrieve data from a remote web service and you want to catch any exceptions from that service and react uniquely.
```
/* recommended */
angular
    .module('blocks.exception')
    .factory('exception', exception);

exception.$inject = ['logger'];

function exception(logger) {
    var service = {
        catcher: catcher
    };
    return service;

    function catcher(message) {
        return function(reason) {
            logger.error(message, reason);
        };
    }
}
```

Route Errors

[Style Y112]

Handle and log all routing errors using $routeChangeError.

Why?: Provides a consistent way handle all routing errors.

Why?: Potentially provides a better user experience if a routing error occurs and you route them to a friendly screen with more details or recovery options.

/* recommended */
function handleRoutingErrors() {
    /**
     * Route cancellation:
     * On routing error, go to the dashboard.
     * Provide an exit clause if it tries to do it twice.
     */
    $rootScope.$on('$routeChangeError',
        function(event, current, previous, rejection) {
            var destination = (current && (current.title || current.name || current.loadedTemplateUrl)) ||
                'unknown target';
            var msg = 'Error routing to ' + destination + '. ' + (rejection.msg || '');
            /**
             * Optionally log using a custom service or $log.
             * (Don't forget to inject custom service)
             */
            logger.warning(msg, [current]);
        }
    );
}

Back to top

Naming

Naming Guidelines

[Style Y120]

Use consistent names for all components following a pattern that describes the component's feature then (optionally) its type. My recommended pattern is feature.type.js. There are 2 names for most assets:
- the file name (avengers.controller.js)
- the registered component name with Angular (AvengersController)
Why?: Naming conventions help provide a consistent way to find content at a glance. Consistency within the project is vital. Consistency with a team is important. Consistency across a company provides tremendous efficiency.

Why?: The naming conventions should simply help you find your code faster and make it easier to understand.

Feature File Names

[Style Y121]

Use consistent names for all components following a pattern that describes the component's feature then (optionally) its type. My recommended pattern is feature.type.js.

Why?: Provides a consistent way to quickly identify components.

Why?: Provides pattern matching for any automated tasks.

/**
 * common options 
 */

// Controllers
avengers.js
avengers.controller.js
avengersController.js

// Services/Factories
logger.js
logger.service.js
loggerService.js

/**
 * recommended
 */

// controllers
avengers.controller.js
avengers.controller.spec.js

// services/factories
logger.service.js
logger.service.spec.js

// constants
constants.js

// module definition
avengers.module.js

// routes
avengers.routes.js
avengers.routes.spec.js

// configuration
avengers.config.js

// directives
avenger-profile.directive.js
avenger-profile.directive.spec.js

Note: Another common convention is naming controller files without the word controller in the file name such as avengers.js instead of avengers.controller.js. All other conventions still hold using a suffix of the type. Controllers are the most common type of component so this just saves typing and is still easily identifiable. I recommend you choose 1 convention and be consistent for your team.

```javascript
/**
 * recommended
 */
// Controllers
avengers.js
avengers.spec.js
```

Test File Names

[Style Y122]

Name test specifications similar to the component they test with a suffix of spec.

Why?: Provides a consistent way to quickly identify components.

Why?: Provides pattern matching for karma or other test runners.
```
/**
 * recommended
 */
avengers.controller.spec.js
logger.service.spec.js
avengers.routes.spec.js
avenger-profile.directive.spec.js
```

Controller Names

[Style Y123]

Use consistent names for all controllers named after their feature. Use UpperCamelCase for controllers, as they are constructors.

Why?: Provides a consistent way to quickly identify and reference controllers.

Why?: UpperCamelCase is conventional for identifying object that can be instantiated using a constructor.
```
/**
 * recommended
 */

// avengers.controller.js
angular
    .module
    .controller('HeroAvengers', HeroAvengers);

function HeroAvengers(){ }
```

Controller Name Suffix

[Style Y124]

Append the controller name with the suffix Controller or with no suffix. Choose 1, not both.

Why?: The Controller suffix is more commonly used and is more explicitly descriptive.

Why?: Omitting the suffix is more succinct and the controller is often easily identifiable even without the suffix.

/**
 * recommended: Option 1
 */

// avengers.controller.js
angular
    .module
    .controller('Avengers', Avengers);

function Avengers(){ }

/**
 * recommended: Option 2
 */

// avengers.controller.js
angular
    .module
    .controller('AvengersController', AvengersController);

function AvengersController(){ }

Factory Names

[Style Y125]

Use consistent names for all factories named after their feature. Use camel-casing for services and factories.

Why?: Provides a consistent way to quickly identify and reference factories.
```
/**
 * recommended
 */

// logger.service.js
angular
    .module
    .factory('logger', logger);

function logger(){ }
```

Directive Component Names

[Style Y126]

Use consistent names for all directives using camel-case. Use a short prefix to describe the area that the directives belong (some example are company prefix or project prefix).

Why?: Provides a consistent way to quickly identify and reference components.
```
/**
 * recommended
 */

// avenger-profile.directive.js    
angular
    .module
    .directive('xxAvengerProfile', xxAvengerProfile);

// usage is <xx-avenger-profile> </xx-avenger-profile>

function xxAvengerProfile(){ }
```

Modules

[Style Y127]

When there are multiple modules, the main module file is named app.module.js while other dependent modules are named after what they represent. For example, an admin module is named admin.module.js. The respective registered module names would be app and admin.

*Why?*: Provides consistency for multiple module apps, and for expanding to large applications.

*Why?*: Provides easy way to use task automation to load all module definitions first, then all other angular files (for bundling).

Configuration

[Style Y128]

Separate configuration for a module into its own file named after the module. A configuration file for the main app module is named app.config.js (or simply config.js). A configuration for a module named admin.module.js is named admin.config.js.

Why?: Separates configuration from module definition, components, and active code.

Why?: Provides a identifiable place to set configuration for a module.

Routes

[Style Y129]

Separate route configuration into its own file. Examples might be app.route.js for the main module and admin.route.js for the admin module. Even in smaller apps I prefer this separation from the rest of the configuration.

Back to top

Application Structure LIFT Principle

LIFT

[Style Y140]

Structure your app such that you can Locate your code quickly, Identify the code at a glance, keep the Flattest structure you can, and Try to stay DRY. The structure should follow these 4 basic guidelines.

Why LIFT?: Provides a consistent structure that scales well, is modular, and makes it easier to increase developer efficiency by finding code quickly. Another way to check your app structure is to ask yourself: How quickly can you open and work in all of the related files for a feature?

When I find my structure is not feeling comfortable, I go back and revisit these LIFT guidelines
1. Locating our code is easy
2. Identify code at a glance
3. Flat structure as long as we can
4. Try to stay DRY (Don’t Repeat Yourself) or T-DRY

Locate

[Style Y141]

Make locating your code intuitive, simple and fast.

Why?: I find this to be super important for a project. If the team cannot find the files they need to work on quickly, they will not be able to work as efficiently as possible, and the structure needs to change. You may not know the file name or where its related files are, so putting them in the most intuitive locations and near each other saves a ton of time. A descriptive folder structure can help with this.
```
/bower_components
/client
  /app
    /avengers
    /blocks
      /exception
      /logger
    /core
    /dashboard
    /data
    /layout
    /widgets
  /content
  index.html
.bower.json
```

Identify

[Style Y142]

When you look at a file you should instantly know what it contains and represents.

Why?: You spend less time hunting and pecking for code, and become more efficient. If this means you want longer file names, then so be it. Be descriptive with file names and keeping the contents of the file to exactly 1 component. Avoid files with multiple controllers, multiple services, or a mixture. There are deviations of the 1 per file rule when I have a set of very small features that are all related to each other, they are still easily identifiable.

Flat

[Style Y143]

Keep a flat folder structure as long as possible. When you get to 7+ files, begin considering separation.

Why?: Nobody wants to search 7 levels of folders to find a file. Think about menus on web sites … anything deeper than 2 should take serious consideration. In a folder structure there is no hard and fast number rule, but when a folder has 7-10 files, that may be time to create subfolders. Base it on your comfort level. Use a flatter structure until there is an obvious value (to help the rest of LIFT) in creating a new folder.

T-DRY (Try to Stick to DRY)

[Style Y144]

Be DRY, but don't go nuts and sacrifice readability.

Why?: Being DRY is important, but not crucial if it sacrifices the others in LIFT, which is why I call it T-DRY. I don’t want to type session-view.html for a view because, well, it’s obviously a view. If it is not obvious or by convention, then I name it.

Back to top

Application Structure

Overall Guidelines

[Style Y150]

Have a near term view of implementation and a long term vision. In other words, start small and but keep in mind on where the app is heading down the road. All of the app's code goes in a root folder named app. All content is 1 feature per file. Each controller, service, module, view is in its own file. All 3rd party vendor scripts are stored in another root folder and not in the app folder. I didn't write them and I don't want them cluttering my app (bower_components, scripts, lib).

Note: Find more details and reasoning behind the structure at [this original post on application structure](http://www.johnpapa.net/angular-app-structuring-guidelines/).

Layout

[Style Y151]

Place components that define the overall layout of the application in a folder named layout. These may include a shell view and controller may act as the container for the app, navigation, menus, content areas, and other regions.

Why?: Organizes all layout in a single place re-used throughout the application.

Folders-by-Feature Structure

[Style Y152]

Create folders named for the feature they represent. When a folder grows to contain more than 7 files, start to consider creating a folder for them. Your threshold may be different, so adjust as needed.

Why?: A developer can locate the code, identify what each file represents at a glance, the structure is flat as can be, and there is no repetitive nor redundant names.

Why?: The LIFT guidelines are all covered.

Why?: Helps reduce the app from becoming cluttered through organizing the content and keeping them aligned with the LIFT guidelines.

Why?: When there are a lot of files (10+) locating them is easier with a consistent folder structures and more difficult in flat structures.

/**
 * recommended
 */

app/
    app.module.js
    app.config.js
    app.routes.js
    components/       
        calendar.directive.js  
        calendar.directive.html  
        user-profile.directive.js  
        user-profile.directive.html  
    layout/
        shell.html      
        shell.controller.js
        topnav.html      
        topnav.controller.js       
    people/
        attendees.html
        attendees.controller.js  
        speakers.html
        speakers.controller.js
        speaker-detail.html
        speaker-detail.controller.js
    services/       
        data.service.js  
        localstorage.service.js
        logger.service.js   
        spinner.service.js
    sessions/
        sessions.html      
        sessions.controller.js
        session-detail.html
        session-detail.controller.js

Note: Do not use structuring using folders-by-type. This requires moving to multiple folders when working on a feature and gets unwieldy quickly as the app grows to 5, 10 or 25+ views and controllers (and other features), which makes it more difficult than folder-by-feature to locate files.

/* 
* avoid
* Alternative folders-by-type.
* I recommend "folders-by-feature", instead.
*/

app/
    app.module.js
    app.config.js
    app.routes.js
    controllers/
        attendees.js            
        session-detail.js       
        sessions.js             
        shell.js                
        speakers.js             
        speaker-detail.js       
        topnav.js               
    directives/       
        calendar.directive.js  
        calendar.directive.html  
        user-profile.directive.js  
        user-profile.directive.html  
    services/       
        dataservice.js  
        localstorage.js
        logger.js   
        spinner.js
    views/
        attendees.html     
        session-detail.html
        sessions.html      
        shell.html         
        speakers.html      
        speaker-detail.html
        topnav.html

Back to top

Modularity

Many Small, Self Contained Modules

[Style Y160]

Create small modules that encapsulate one responsibility.

Why?: Modular applications make it easy to plug and go as they allow the development teams to build vertical slices of the applications and roll out incrementally. This means we can plug in new features as we develop them.

Create an App Module

[Style Y161]

Create an application root module whose role is pull together all of the modules and features of your application. Name this for your application.

Why?: AngularJS encourages modularity and separation patterns. Creating an application root module whose role is to tie your other modules together provides a very straightforward way to add or remove modules from your application.

Keep the App Module Thin

[Style Y162]

Only put logic for pulling together the app in the application module. Leave features in their own modules.

Why?: Adding additional roles to the application root to get remote data, display views, or other logic not related to pulling the app together muddies the app module and make both sets of features harder to reuse or turn off.

Why?: The app module becomes a manifest that describes which modules help define the application.

Feature Areas are Modules

[Style Y163]

Create modules that represent feature areas, such as layout, reusable and shared services, dashboards, and app specific features (e.g. customers, admin, sales).

Why?: Self contained modules can be added to the application with little or no friction.

Why?: Sprints or iterations can focus on feature areas and turn them on at the end of the sprint or iteration.

Why?: Separating feature areas into modules makes it easier to test the modules in isolation and reuse code.

Reusable Blocks are Modules

[Style Y164]

Create modules that represent reusable application blocks for common services such as exception handling, logging, diagnostics, security, and local data stashing.

Why?: These types of features are needed in many applications, so by keeping them separated in their own modules they can be application generic and be reused across applications.

Module Dependencies

[Style Y165]

The application root module depends on the app specific feature modules and any shared or reusable modules.

Why?: The main app module contains a quickly identifiable manifest of the application's features.

Why?: Each feature area contains a manifest of what it depends on, so it can be pulled in as a dependency in other applications and still work.

Why?: Intra-App features such as shared data services become easy to locate and share from within app.core (choose your favorite name for this module).

Note: This is a strategy for consistency. There are many good options here. Choose one that is consistent, follows AngularJS's dependency rules, and is easy to maintain and scale.

My structures vary slightly between projects but they all follow these guidelines for structure and modularity. The implementation may vary depending on the features and the team. In other words, don't get hung up on an exact like-for-like structure but do justify your structure using consistency, maintainability, and efficiency in mind.

In a small app, you can also consider putting all the shared dependencies in the app module where the feature modules have no direct dependencies. This makes it easier to maintain the smaller application, but makes it harder to reuse modules outside of this application.

Back to top

Startup Logic

Configuration

[Style P170]

Inject code into module configuration that must be configured before running the angular app. Ideal candidaes include providers and constants.

Why?: This makes it easier to have a less places for configuration.

angular
    .module('app')
    .config(configure);

configure.$inject = 
    ['routerHelperProvider', 'exceptionHandlerProvider', 'toastr'];

function configure (routerHelperProvider, exceptionHandlerProvider, toastr) {
    exceptionHandlerProvider.configure(config.appErrorPrefix);
    configureStateHelper();

    toastr.options.timeOut = 4000;
    toastr.options.positionClass = 'toast-bottom-right';

    ////////////////

    function configureStateHelper() {
        routerHelperProvider.configure({
            docTitle: 'NG-Modular: '
        });
    }
}

Run Blocks

[Style P171]

Any code that needs to run when an application starts should be declared in a factory, exposed via a function, and injected into the run block.

Why?: Code directly in a run block can be difficult to test. Placing in a factory makes it easier to abstract and mock.

angular
    .module('app')
    .run(runBlock);

  runBlock.$inject = ['authenticator', 'translator'];

  function runBlock(authenticator, translator) {
      authenticator.initialize();
      translator.initialize();
  }

Back to top

Angular $ Wrapper Services

$document and $window

[Style Y180]

Use $document and $window instead of document and window.

Why?: These services are wrapped by Angular and more easily testable than using document and window in tests. This helps you avoid having to mock document and window yourself.

$timeout and $interval

[Style Y181]

Use $timeout and $interval instead of setTimeout and setInterval .

Why?: These services are wrapped by Angular and more easily testable and handle AngularJS's digest cycle thus keeping data binding in sync.

Back to top

Testing

Unit testing helps maintain clean code, as such I included some of my recommendations for unit testing foundations with links for more information.

Write Tests with Stories

[Style Y190]

Write a set of tests for every story. Start with an empty test and fill them in as you write the code for the story.

Why?: Writing the test descriptions helps clearly define what your story will do, will not do, and how you can measure success.

it('should have Avengers controller', function() {
    //TODO
});

it('should find 1 Avenger when filtered by name', function() {
    //TODO
});

it('should have 10 Avengers', function() {
    //TODO (mock data?)
});

it('should return Avengers via XHR', function() {
    //TODO ($httpBackend?)
});

// and so on

Testing Library

[Style Y191]

Use Jasmine or Mocha for unit testing.

Why?: Both Jasmine and Mocha are widely used in the AngularJS community. Both are stable, well maintained, and provide robust testing features.

Note: When using Mocha, also consider choosing an assert library such as Chai.

Test Runner

[Style Y192]

Use Karma as a test runner.

Why?: Karma is easy to configure to run once or automatically when you change your code.

Why?: Karma hooks into your Continuous Integration process easily on its own or through Grunt or Gulp.

Why?: Some IDE's are beginning to integrate with Karma, such as WebStorm and Visual Studio.

Why?: Karma works well with task automation leaders such as Grunt (with grunt-karma) and Gulp (with gulp-karma).

Stubbing and Spying

[Style Y193]

Use Sinon for stubbing and spying.

Why?: Sinon works well with both Jasmine and Mocha and extends the stubbing and spying features they offer.

Why?: Sinon makes it easier to toggle between Jasmine and Mocha, if you want to try both.

Headless Browser

[Style Y194]

Use PhantomJS to run your tests on a server.

Why?: PhantomJS is a headless browser that helps run your tests without needing a "visual" browser. So you do not have to install Chrome, Safari, IE, or other browsers on your server.

Note: You should still test on all browsers in your environment, as appropriate for your target audience.

Code Analysis

[Style Y195]

Run JSHint on your tests.

Why?: Tests are code. JSHint can help identify code quality issues that may cause the test to work improperly.

Alleviate Globals for JSHint Rules on Tests

[Style Y196]

Relax the rules on your test code to allow for common globals such as describe and expect.

Why?: Your tests are code and require the same attention and code quality rules as all of your production code. However, global variables used by the testing framework, for example, can be relaxed by including this in your test specs.
```
/* global sinon, describe, it, afterEach, beforeEach, expect, inject */
```

Back to top

Animations

Usage

[Style Y210]

Use subtle animations with AngularJS to transition between states for views and primary visual elements. Include the ngAnimate module. The 3 keys are subtle, smooth, seamless.

Why?: Subtle animations can improve User Experience when used appropriately.

Why?: Subtle animations can improve perceived performance as views transition.

Sub Second

[Style Y211]

Use short durations for animations. I generally start with 300ms and adjust until appropriate.

Why?: Long animations can have the reverse affect on User Experience and perceived performance by giving the appearance of a slow application.

animate.css

[Style Y212]

Use animate.css for conventional animations.

Why?: The animations that animate.css provides are fast, smooth, and easy to add to your application.

Why?: Provides consistency in your animations.

Why?: animate.css is widely used and tested.

Note: See this great post by Matias Niemelä on AngularJS animations

Back to top

Comments

jsDoc

[Style Y220]

If planning to produce documentation, use jsDoc syntax to document function names, description, params and returns. Use @namespace and @memberOf to match your app structure.

Why?: You can generate (and regenerate) documentation from your code, instead of writing it from scratch.

Why?: Provides consistency using a common industry tool.

/**
 * Logger Factory
 * @namespace Factories
 */
(function() {
  angular
      .module('app')
      .factory('logger', logger);

  /**
   * @namespace Logger
   * @desc Application wide logger
   * @memberOf Factories
   */
  function logger($log) {
      var service = {
         logError: logError
      };
      return service;

      ////////////

      /**
       * @name logError
       * @desc Logs errors
       * @param {String} msg Message to log 
       * @returns {String}
       * @memberOf Factories.Logger
       */
      function logError(msg) {
          var loggedMsg = 'Error: ' + msg;
          $log.error(loggedMsg);
          return loggedMsg;
      };
  }
})();

Back to top

JS Hint

Use an Options File

[Style Y230]

Use JS Hint for linting your JavaScript and be sure to customize the JS Hint options file and include in source control. See the JS Hint docs for details on the options.

Why?: Provides a first alert prior to committing any code to source control.

Why?: Provides consistency across your team.

{
    "bitwise": true,
    "camelcase": true,
    "curly": true,
    "eqeqeq": true,
    "es3": false,
    "forin": true,
    "freeze": true,
    "immed": true,
    "indent": 4,
    "latedef": "nofunc",
    "newcap": true,
    "noarg": true,
    "noempty": true,
    "nonbsp": true,
    "nonew": true,
    "plusplus": false,
    "quotmark": "single",
    "undef": true,
    "unused": false,
    "strict": false,
    "maxparams": 10,
    "maxdepth": 5,
    "maxstatements": 40,
    "maxcomplexity": 8,
    "maxlen": 120,

    "asi": false,
    "boss": false,
    "debug": false,
    "eqnull": true,
    "esnext": false,
    "evil": false,
    "expr": false,
    "funcscope": false,
    "globalstrict": false,
    "iterator": false,
    "lastsemic": false,
    "laxbreak": false,
    "laxcomma": false,
    "loopfunc": true,
    "maxerr": false,
    "moz": false,
    "multistr": false,
    "notypeof": false,
    "proto": false,
    "scripturl": false,
    "shadow": false,
    "sub": true,
    "supernew": false,
    "validthis": false,
    "noyield": false,

    "browser": true,
    "node": true,

    "globals": {
        "angular": false,
        "$": false
    }
}

Back to top

Constants

Vendor Globals

[Style Y240]

Create an AngularJS Constant for vendor libraries' global variables.

Why?: Provides a way to inject vendor libraries that otherwise are globals. This improves code testability by allowing you to more easily know what the dependencies of your components are (avoids leaky abstractions). It also allows you to mock these dependencies, where it makes sense.
```
// constants.js

/* global toastr:false, moment:false */
(function() {
    'use strict';

    angular
        .module('app.core')
        .constant('toastr', toastr)
        .constant('moment', moment);
})();
```

Back to top

File Templates and Snippets

Use file templates or snippets to help follow consistent styles and patterns. Here are templates and/or snippets for some of the web development editors and IDEs.

Sublime Text

[Style Y250]

AngularJS snippets that follow these styles and guidelines.
- Download the Sublime Angular snippets
- Place it in your Packages folder
- Restart Sublime
- In a JavaScript file type these commands followed by a TAB
```
ngcontroller // creates an Angular controller
ngdirective // creates an Angular directive
ngfactory // creates an Angular factory
ngmodule // creates an Angular module
```

Visual Studio

[Style Y251]

AngularJS file templates that follow these styles and guidelines can be found at SideWaffle
- Download the SideWaffle Visual Studio extension (vsix file)
- Run the vsix file
- Restart Visual Studio

WebStorm

[Style Y252]

AngularJS snippets and file templates that follow these styles and guidelines. You can import them into your WebStorm settings:
- Download the WebStorm AngularJS file templates and snippets
- Open WebStorm and go to the File menu
- Choose the Import Settings menu option
- Select the file and click OK
- In a JavaScript file type these commands followed by a TAB:
```
ng-c // creates an Angular controller
ng-f // creates an Angular factory
ng-m // creates an Angular module
```

Back to top

AngularJS docs

For anything else, API reference, check the Angular documentation.

Contributing

Open an issue first to discuss potential changes/additions. If you have questions with the guide, feel free to leave them as issues in the repository. If you find a typo, create a pull request. The idea is to keep the content up to date and use github’s native feature to help tell the story with issues and PR’s, which are all searchable via google. Why? Because odds are if you have a question, someone else does too! You can learn more here at about how to contribute.

By contributing to this repository you are agreeing to make your content available subject to the license of this repository.

Process

1. Discuss the changes in an Issue. 
2. Open a Pull Request, reference the issue, and explain the change and why it adds value.
3. The Pull Request will be evaluated and either merged or declined.

License

tldr; Use this guide. Attributions are appreciated.

(The MIT License)

Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the 'Software'), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

Back to top

Name		Name	Last commit message	Last commit date
Latest commit History 386 Commits
assets		assets
i18n		i18n
LICENSE		LICENSE
README.md		README.md

License

joelbdavis/angularjs-styleguide

Folders and files

Latest commit

History

Repository files navigation

AngularJS Style Guide

See the Styles in a Sample App

Table of Contents

Single Responsibility

Rule of 1

[Style P001]

IIFE

JavaScript Closures

[Style P010]

Modules

Avoid Naming Collisions

[Style P020]

Definitions (aka Setters)

[Style P021]

Getters

[Style P022]

Setting vs Getting

[Style P023]

Named vs Anonymous Functions

[Style P024]

Controllers

controllerAs View Syntax

[Style P030]

controllerAs Controller Syntax

[Style P031]

controllerAs with capture variable

[Style F032]

Bindable Members Up Top

[Style P033]

Function Declarations to Hide Implementation Details

[Style P034]

Defer Controller Logic

[Style P035]

Keep Controllers Focused

[Style P037]

Assigning Controllers

[Style P038]

Services

Singletons

[Style Y040]

Factories

Single Responsibility

[Style Y050]

Singletons

[Style Y051]

[Style T001]

Data Services

Separate Data Calls

[Style P060]

Return a Promise from Data Calls

[Style P061]

Directives

Limit 1 Per File

[Style P070]

Manipulate DOM in a Directive

[Style P072]

Provide a Unique Directive Prefix - fss?

[Style P073]

Restrict to Elements and Attributes

[Style Y074]

Directives and ControllerAs

[Style Y075]

Resolving Promises for a Controller

Controller Activation Promises

[Style Y080]

Route Resolve Promises

[Style Y081]

Manual Annotating for Dependency Injection

UnSafe from Minification

[Style Y090]

Manually Identify Dependencies

[Style Y091]

Manually Identify Route Resolver Dependencies

[Style Y092]