Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbic-migration prepare - warning message when Schema version from package declaration #113

Closed
kivilahtio opened this issue Aug 28, 2018 · 4 comments

Comments

@kivilahtio
Copy link

Hi!

To reproduce the warning:

Initially
Having no database installed yet, running
dbic-migration status
prints

Schema is 1
Database is not currently installed

Given my
MusicBase/Schema.pm
has package declaration
package MusicBase::Schema 1;
instead of using
our $VERSION = 1;

When running command
dbic-migration prepare
I get a warning
operation not supported with version object at /usr/local/share/perl/5.26.1/DBIx/Class/Migration.pm line 274.
But it looks like the files generated in the share-dir are the same when using package or $VERSION versioning scheme.
When running
dbic-migration prepare
with the versioning scheme
our $VERSION = 1;
I get the expected warning
There is no current database deployed, so I can't prepare upgrades or downgrades

What I was expecting:
To not see a warning, but still receive correct functionality.
OR
The warning to be escalated to an exception and the program to stop doing anything useful looking.

@KES777
Copy link

KES777 commented Sep 1, 2018

Please read this. If I wrong, please provide further comments.

@KES777
Copy link

KES777 commented Sep 1, 2018

This is not belongs to your problem. but may you please comment this idea: #95?

@mohawk2
Copy link
Collaborator

mohawk2 commented Feb 25, 2019

I've made a branch (handle-version-obj) with DBICM's half of the required fixes. However, until frioux/DBIx-Class-DeploymentHandler#63 is merged and released, it can't be merged (with updated dependency requirement) and released.

@mohawk2 mohawk2 reopened this Feb 25, 2019
@mohawk2 mohawk2 closed this as completed in 4892d03 Mar 7, 2019
@mohawk2
Copy link
Collaborator

mohawk2 commented Mar 7, 2019

Now released as 0.065. DBICDH released as 0.002223.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants