Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rnsdk] External api module not added for SDK #2527

Open
Anfieldd opened this issue May 16, 2024 · 1 comment
Open

[rnsdk] External api module not added for SDK #2527

Anfieldd opened this issue May 16, 2024 · 1 comment

Comments

@Anfieldd
Copy link

Hi guys! With one of the last stables notifyTranscriptionChunkReceived function was added.
export const notifyTranscriptionChunkReceived = (transcriptMessageID: string, language: string, participant: Object, text: any, _store?: any) => sendEvent( _store, TRANSCRIPTION_CHUNK_RECEIVED, { messageID: transcriptMessageID, language, participant, text });

This function uses the ExternalAPI native module which wasn't added to the prepare_sdk script and my subtitles didn't work.
I fixed it for ios by adding this code to the prepare_sdk script
fs.copyFileSync( ${iosSrcPath}/ExternalAPI.m, ${iosDestPath}/ExternalAPI.m); fs.copyFileSync(${iosSrcPath}/ExternalAPI.h, ${iosDestPath}/ExternalAPI.h); fs.copyFileSync(${androidSourcePath}/ExternalAPIModule.java, ${androidTargetPath}/ExternalAPIModule.java );
And in react-native-sdk/android/src/main/java/org/jitsi/meet/sdk/JitsiMeetReactNativePackage.java
new ExternalAPIModule(reactContext),
But for android I have a lot of errors during the build in ExternalAPIModule.java file.
Screenshot 2024-05-16 at 20 14 14
Could you help me with this or maybe you can update the prepare_sdk script for last stables? Thanks!

@saghul
Copy link
Member

saghul commented May 17, 2024

The rnsdk doesn't use that ExternalAPI because that one is for the native implementation. That said, we should be exposing this event on the rnsdk too. @Calinteodor PTAL when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants