From 1788f06318f47684f8a0703106280f9a2ad1870f Mon Sep 17 00:00:00 2001 From: bbaldino Date: Thu, 24 Jan 2019 12:43:00 -0800 Subject: [PATCH] use compareTo when comparing Jids (#339) the previous code was causing an issue where we'd compare the same JID content (but different references) and Jicofo thought they weren't the same. --- .../java/org/jitsi/jicofo/recording/jibri/JibriSession.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/jitsi/jicofo/recording/jibri/JibriSession.java b/src/main/java/org/jitsi/jicofo/recording/jibri/JibriSession.java index 434774c2d9..50318d1edd 100644 --- a/src/main/java/org/jitsi/jicofo/recording/jibri/JibriSession.java +++ b/src/main/java/org/jitsi/jicofo/recording/jibri/JibriSession.java @@ -490,10 +490,10 @@ private void handleJibriStatusUpdate( jibriStatus = newStatus; logger.info("Got Jibri status update: Jibri " + jibriJid + " has status " + newStatus + " and failure reason " + failureReason); - if (jibriJid != currentJibriJid) + if (jibriJid.compareTo(currentJibriJid) != 0) { logger.info("This status update is from " + jibriJid + - "but the current Jibri is " + currentJibriJid + ", ignoring"); + " but the current Jibri is " + currentJibriJid + ", ignoring"); return; } // First: if we're no longer pending (regardless of the Jibri's new state), make sure we stop