Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dubious responsive images code on the download page for the app logos #62

Open
dandv opened this issue Jun 25, 2020 · 1 comment
Open

Comments

@dandv
Copy link
Contributor

dandv commented Jun 25, 2020

The code at https://jitsi.org/downloads/ has this markup for responsive images, which doesn't seem to make sense:

  • max-width: 148px will pretty much never be true
  • the default width is equal to the max-width
  • the default width is 148px, but the smallest image width is 300w
  • the second image in the srcSet will never be used
  • the width="xxx" and height="50" are forced anyway
<a href="https://itunes.apple.com/us/app/jitsi-meet/id1165103905">
  <img src="https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/appstore-badge-300x101.png"
    alt="" width="148" height="50"
    srcSet="https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/appstore-badge-300x101.png 300w,
    https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/appstore-badge.png 498w"
    sizes="(max-width: 148px) 100vw, 148px"
  />
</a>
<a href="https://play.google.com/store/apps/details?id=org.jitsi.meet">
  <img src="https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/google-play-badge-300x89.png"
    alt="" width="169" height="50"
    srcSet="https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/google-play-badge-300x89.png 300w,
    https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/google-play-badge.png 563w"
    sizes="(max-width: 169px) 100vw, 169px"
  />
</a>
<a href="https://f-droid.org/en/packages/org.jitsi.meet/">
  <img src="https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/f-droid-badge-300x89.png"
    alt="" width="169" height="50"
    srcSet="https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/f-droid-badge-300x89.png 300w,
    https://335wvf48o1332cksy23mw1pj-wpengine.netdna-ssl.com/wp-content/uploads/2019/11/f-droid-badge.png 563w"
    sizes="(max-width: 169px) 100vw, 169px"
  />
</a>

Also, the alt attribute is empty.

@saghul
Copy link
Member

saghul commented Jul 7, 2020

(shakes fist at wordpress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants