Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete documentation #303

Open
xXTraceXx opened this issue Apr 8, 2022 · 3 comments
Open

Incomplete documentation #303

xXTraceXx opened this issue Apr 8, 2022 · 3 comments

Comments

@xXTraceXx
Copy link

Hello,

i am working with lib-jitsi-meet. I found the setReceiverVideoConstraint(resolution) in the documation (lib-jitsi-meet API (low level) | Jitsi Meet ) but it feels incomplete to me. The argument resolution for example is not really documented and i dont’t know if it is a object or a string, just to mention two examples.

Same with the effect object in the method setEffect method. I guess a lot of developers have to guess what u mean by effect or resolution.

If you give me the necessary information i will do an improved version of the documetion via pull request.

Thanks for your work

@saghul
Copy link
Member

saghul commented May 6, 2022

Ping @jallamsetty1 iin case you have some spare cycles...

@jallamsetty1
Copy link
Member

jallamsetty1 commented May 10, 2022

I will add this to my list. Also, setReceiverVideoConstraint is deprecated and one should instead use setReceiverConstraints

@abhijain2003
Copy link

did you changed the code,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants