Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed Fixnum reference #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sujangandikote
Copy link

Fixnum and Bignum are combined into Integer class Since Ruby-2.4.0 release. This fix is to remove all Fixnum reference.

Fixnum and Bignum are combined into Integer class Since Ruby-2.4.0 release. This fix is to remove all Fixnum reference.
@hsbt
Copy link

hsbt commented Feb 18, 2019

@tenderlove Do you have a commit bit of this repository? I always get the warnings that are builder-2.1.2/lib/builder/xchar.rb:22: warning: constant ::Fixnum is deprecated when I invoked rubygems and bundler tests.

@tenderlove
Copy link

@hsbt no, but I have gem release access. Send the PR here: https://github.com/tenderlove/builder

@hsbt
Copy link

hsbt commented Feb 18, 2019

@tenderlove Thanks, I understood it.

@kbrock
Copy link

kbrock commented Feb 19, 2024

@sujangandikote looks like this has been merged in tenderlove. can we close?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants