Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tmux-prefix-highlight? #28

Open
Blake-LeBlanc opened this issue May 8, 2019 · 4 comments
Open

Add support for tmux-prefix-highlight? #28

Blake-LeBlanc opened this issue May 8, 2019 · 4 comments
Assignees
Milestone

Comments

@Blake-LeBlanc
Copy link

Excellent pack of themes you have here jimeh!

Is it possible an option could be added to support the tmux-prefix-highlight plugin out of the box? I consider it a very useful plugin when interacting with multiple windows.

In the meantime, I've gone through the theme I use and manually added the tmux-prefix-highlight indicator to the status line.

Thank you again!
-Blake

@jimeh
Copy link
Owner

jimeh commented May 11, 2019

I hadn't come across that plugin before, but I definitely want it :D

I'm currently working on a refractor of the themes to allow full user customization, once done I'll have a look at adding built-in support for prefix- highlight :)

@lovesegfault
Copy link

Any news on this? It'd be awesome to get this integrated :)

@jimeh
Copy link
Owner

jimeh commented Oct 28, 2019

I've got a major refactor in #30 that's laying the groundwork for being able to customize, and add new features to all themes easily. I'll be adding support for the tmux-prefix-highlight plugin once #30 is merged in :)

@jimeh jimeh added this to the 1.2.0 milestone Dec 22, 2019
@jimeh
Copy link
Owner

jimeh commented Dec 23, 2019

@Blake-LeBlanc @lovesegfault I have this implemented in #34 now. If you guys wouldn't mind having a look and see what you think, that'd be great :)

I couldn't easily integrate the tmux-prefix-highlight plugin and make it play as nice with the powerline themes as I would have liked, so I implemented a custom solution instead.

  • Pros:
    • Everyone gets it, regardless of if they have the tmux-prefix-highlight plugin or not.
    • It's possible to make it play really nice and properly fit in with the powerline themes.
  • Cons:
    • Not fully as flexible and configurable as tmux-prefix-highlight.

@jimeh jimeh self-assigned this Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants