-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/reduce code duplication in plugins #31
base: refactored
Are you sure you want to change the base?
Refactor/reduce code duplication in plugins #31
Commits on Apr 15, 2022
-
Refactored ClassRegistry to reduce code duplication
The duplicated methods per type `style style_XXX_class`, `generate_XXX` and `reference_XXX` were abstracted into a BaseTypeRegistry class. Provided a specific XXXTypeRegistry for every required type and added it as an attribute to the ClassRegistry.
Configuration menu - View commit details
-
Copy full SHA for 6a2898d - Browse repository at this point
Copy the full SHA 6a2898dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f4b088 - Browse repository at this point
Copy the full SHA 3f4b088View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8c07759 - Browse repository at this point
Copy the full SHA 8c07759View commit details -
Made generate_enums a "private" method of EnumsPlugin. Decoupled value parsing and code generation, by moving the generation of Ast-Elements into a separate class.
Configuration menu - View commit details
-
Copy full SHA for 006a1b0 - Browse repository at this point
Copy the full SHA 006a1b0View commit details
Commits on Apr 16, 2022
-
Added tests for InputsPlugin with 100% coverage to prepare refactoring
Changed the generation of deprecation-reasons to print the deprecation reason after `DEPRECATED` instead of the field description.
Configuration menu - View commit details
-
Copy full SHA for bac1f5b - Browse repository at this point
Copy the full SHA bac1f5bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d8c045a - Browse repository at this point
Copy the full SHA d8c045aView commit details
Commits on Apr 17, 2022
-
Refactored generate_input_annotation
Separated ast-generation to static class. Streamlined control flow inside generate_input_annotation.
Configuration menu - View commit details
-
Copy full SHA for 2d3a9d3 - Browse repository at this point
Copy the full SHA 2d3a9d3View commit details -
Moved ast-generators into separate module
A centralized ast-generator module should make the reuse of repeating structures easier and hide the actual code-generation from plugin-developers. Optimized imports
Configuration menu - View commit details
-
Copy full SHA for 66abd5a - Browse repository at this point
Copy the full SHA 66abd5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 00957ad - Browse repository at this point
Copy the full SHA 00957adView commit details -
Made tests for InputsPlugin reusable for ObjectsPlugin
Added tests for ObjectsPlugin that include primitive types and nested object types
Configuration menu - View commit details
-
Copy full SHA for 520aeef - Browse repository at this point
Copy the full SHA 520aeefView commit details -
Configuration menu - View commit details
-
Copy full SHA for e30a955 - Browse repository at this point
Copy the full SHA e30a955View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6438d16 - Browse repository at this point
Copy the full SHA 6438d16View commit details -
Added TestCase for Union-generation and found a potential design-error.
The issue is described in the doctstring to ObjectTypeTestCaseGenerator.make_test_cases_union_field_value()
Configuration menu - View commit details
-
Copy full SHA for d28d259 - Browse repository at this point
Copy the full SHA d28d259View commit details -
Added test for ObjectsPlugin (100%-coverage) to prepare refactoring.
This partially duplicated old tests in test_mro/test_multiple_inheritance
Configuration menu - View commit details
-
Copy full SHA for 7666cc4 - Browse repository at this point
Copy the full SHA 7666cc4View commit details
Commits on Apr 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5edc79f - Browse repository at this point
Copy the full SHA 5edc79fView commit details -
Refactored
generate_object_field_annotation
Fixed bug in ObjectsPlugin._generate_type_body (introduced in last commit) that broke forward references by referencing the wrong "parent" in the subsequent call to generate_object_field_annotation. Added union method to the AnnotationAstGenerator. Refactored last method calls in ClassRegistry that slipped through during the first refactoring.
Configuration menu - View commit details
-
Copy full SHA for 4f5747f - Browse repository at this point
Copy the full SHA 4f5747fView commit details
Commits on Apr 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 507d29a - Browse repository at this point
Copy the full SHA 507d29aView commit details
Commits on May 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 21e6208 - Browse repository at this point
Copy the full SHA 21e6208View commit details