Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Menus don't expand without JavaScript #41

Open
TikhonJelvis opened this issue Jun 1, 2020 · 3 comments
Open

Navigation Menus don't expand without JavaScript #41

TikhonJelvis opened this issue Jun 1, 2020 · 3 comments

Comments

@TikhonJelvis
Copy link

I recently started using NoScript, and I noticed that the subsections on the Pandoc homepage navigation menu (eg links under "Documentation") do not expand without JavaScript enabled. This isn't a real problem for me specifically, but I believe it makes the page difficult to navigate with accessibility tools like screen readers.

I'm not sure about the best way to fix this. Perhaps you could have the subsections expanded by default and use JavaScript to collapse them? Or maybe have a fully-expanded copy of the menu in a noscript block?

@mb21: looks like you worked on the menus recently. Any thoughts on this?

@mb21
Copy link
Contributor

mb21 commented Jun 1, 2020

I only worked on the in-document menus to the right. The links to the left, with classes like navbar-collapse are using Twitter Bootstrap.... but yeah, I'm all in favour of tossing that out... we could write a couple of lines of js ourselves to implement the behaviour you described...

But note that screen readers execute javascript just fine... what bothers me more it that we load the stuff from google... but yeah... https://github.com/jgm/pandoc-website/blob/master/template.html#L29

@jgm
Copy link
Owner

jgm commented Jun 3, 2020

You mean the google analytics? I don't really use that any more, so I wouldn't mind removing it.

jgm added a commit that referenced this issue Jun 3, 2020
@jgm
Copy link
Owner

jgm commented Jun 3, 2020

As for the other issue, if the twitter bootstrap stuff does work with screen readers, then I don't see any reason to mess with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants